X-Git-Url: http://git.efficios.com/?p=babeltrace.git;a=blobdiff_plain;f=formats%2Fctf-text%2Ftypes%2Finteger.c;h=1337eca3ab13df44bb89e7ee5903d381dd743a88;hp=a01284583f6ecdd64e83cc2a9d34c31b00bc0a8f;hb=81dee1bb528a95f7bf2bc622948807150794a75e;hpb=164078da31b3612e3618e8e8046a3866cb22f80e

diff --git a/formats/ctf-text/types/integer.c b/formats/ctf-text/types/integer.c
index a0128458..1337eca3 100644
--- a/formats/ctf-text/types/integer.c
+++ b/formats/ctf-text/types/integer.c
@@ -20,6 +20,7 @@
 #include <stdio.h>
 #include <inttypes.h>
 #include <stdint.h>
+#include <babeltrace/bitfield.h>
 
 int ctf_text_integer_write(struct stream_pos *ppos, struct definition *definition)
 {
@@ -39,25 +40,21 @@ int ctf_text_integer_write(struct stream_pos *ppos, struct definition *definitio
 		fprintf(pos->fp, "%s = ",
 			g_quark_to_string(definition->name));
 
-	switch (integer_declaration->base) {
-	case 2:
-	{
-		int bitnr;
-		uint64_t v = integer_definition->value._unsigned;
+	if (integer_declaration->encoding == CTF_STRING_ASCII
+	    || integer_declaration->encoding == CTF_STRING_UTF8) {
 
-		fprintf(pos->fp, "b");
-		for (bitnr = 0; bitnr < integer_declaration->len; bitnr++)
-			v <<= 1;
-		for (; bitnr < sizeof(v) * CHAR_BIT; bitnr++) {
-			fprintf(pos->fp, "%u", ((v & 1ULL) << 63) ? 1 : 0);
-			v <<= 1;
+		if (!integer_declaration->signedness) {
+			g_string_append_c(pos->string,
+				(int) integer_definition->value._unsigned);
+		} else {
+			g_string_append_c(pos->string,
+				(int) integer_definition->value._signed);
 		}
-		break;
+		return 0;
 	}
-	case 8:
-		fprintf(pos->fp, "0%" PRIo64,
-			integer_definition->value._unsigned);
-		break;
+
+	switch (integer_declaration->base) {
+	case 0:	/* default */
 	case 10:
 		if (!integer_declaration->signedness) {
 			fprintf(pos->fp, "%" PRIu64,
@@ -67,10 +64,50 @@ int ctf_text_integer_write(struct stream_pos *ppos, struct definition *definitio
 				integer_definition->value._signed);
 		}
 		break;
+	case 2:
+	{
+		int bitnr;
+		uint64_t v;
+
+		if (!integer_declaration->signedness)
+			v = integer_definition->value._unsigned;
+		else
+			v = (uint64_t) integer_definition->value._signed;
+
+		fprintf(pos->fp, "0b");
+		v = _bt_piecewise_lshift(v, 64 - integer_declaration->len);
+		for (bitnr = 0; bitnr < integer_declaration->len; bitnr++) {
+			fprintf(pos->fp, "%u", (v & (1ULL << 63)) ? 1 : 0);
+			v = _bt_piecewise_lshift(v, 1);
+		}
+		break;
+	}
+	case 8:
+	{
+		uint64_t v;
+
+		if (!integer_declaration->signedness)
+			v = integer_definition->value._unsigned;
+		else
+			v = (uint64_t) integer_definition->value._signed;
+
+		fprintf(pos->fp, "0%" PRIo64,
+			integer_definition->value._unsigned);
+		break;
+	}
 	case 16:
+	{
+		uint64_t v;
+
+		if (!integer_declaration->signedness)
+			v = integer_definition->value._unsigned;
+		else
+			v = (uint64_t) integer_definition->value._signed;
+
 		fprintf(pos->fp, "0x%" PRIX64,
 			integer_definition->value._unsigned);
 		break;
+	}
 	default:
 		return -EINVAL;
 	}