X-Git-Url: http://git.efficios.com/?p=babeltrace.git;a=blobdiff_plain;f=formats%2Fctf%2Fmetadata%2Fctf-visitor-generate-io-struct.c;h=4a71a27e04024dae8ecfab95d69cd5854391bc13;hp=6a8e1ab6a69e17107059d5a8919311eb5535df9b;hb=6070d2f1612a27050f14362a910b565b8e70662c;hpb=306eeaa621ff1e69d8b0fcabd71560f62c16c46a

diff --git a/formats/ctf/metadata/ctf-visitor-generate-io-struct.c b/formats/ctf/metadata/ctf-visitor-generate-io-struct.c
index 6a8e1ab6..4a71a27e 100644
--- a/formats/ctf/metadata/ctf-visitor-generate-io-struct.c
+++ b/formats/ctf/metadata/ctf-visitor-generate-io-struct.c
@@ -156,10 +156,20 @@ int get_unary_signed(struct cds_list_head *head, int64_t *value)
 
 	cds_list_for_each_entry(node, head, siblings) {
 		assert(node->type == NODE_UNARY_EXPRESSION);
-		assert(node->u.unary_expression.type == UNARY_UNSIGNED_CONSTANT);
+		assert(node->u.unary_expression.type == UNARY_UNSIGNED_CONSTANT
+			|| node->u.unary_expression.type == UNARY_SIGNED_CONSTANT);
 		assert(node->u.unary_expression.link == UNARY_LINK_UNKNOWN);
 		assert(i == 0);
-		*value = node->u.unary_expression.u.signed_constant;
+		switch (node->u.unary_expression.type) {
+		case UNARY_UNSIGNED_CONSTANT:
+			*value = (int64_t) node->u.unary_expression.u.unsigned_constant;
+			break;
+		case UNARY_SIGNED_CONSTANT:
+			*value = node->u.unary_expression.u.signed_constant;
+			break;
+		default:
+			assert(0);
+		}
 		i++;
 	}
 	return 0;
@@ -1658,12 +1668,12 @@ int ctf_event_declaration_visit(FILE *fd, int depth, struct ctf_node *node, stru
 				goto error;
 			}
 			ret = get_unary_signed(&node->u.ctf_expression.right, &loglevel);
-			event->loglevel = (int) loglevel;
 			if (ret) {
 				fprintf(fd, "[error] %s: unexpected unary expression for event loglevel\n", __func__);
 				ret = -EINVAL;
 				goto error;
 			}
+			event->loglevel = (int) loglevel;
 			CTF_EVENT_SET_FIELD(event, loglevel);
 		} else {
 			fprintf(fd, "[warning] %s: attribute \"%s\" is unknown in event declaration.\n", __func__, left);
@@ -2291,11 +2301,142 @@ void clock_free(gpointer data)
 	g_free(clock);
 }
 
+static
+int ctf_env_declaration_visit(FILE *fd, int depth, struct ctf_node *node,
+		struct ctf_trace *trace)
+{
+	int ret = 0;
+	struct ctf_tracer_env *env = &trace->env;
+
+	switch (node->type) {
+	case NODE_CTF_EXPRESSION:
+	{
+		char *left;
+
+		left = concatenate_unary_strings(&node->u.ctf_expression.left);
+		if (!strcmp(left, "vpid")) {
+			uint64_t v;
+
+			if (env->vpid != -1) {
+				fprintf(fd, "[error] %s: vpid already declared in env declaration\n", __func__);
+				goto error;	/* ret is 0, so not an actual error, just warn. */
+			}
+			ret = get_unary_unsigned(&node->u.ctf_expression.right, &v);
+			if (ret) {
+				fprintf(fd, "[error] %s: unexpected unary expression for env vpid\n", __func__);
+				goto error;	/* ret is 0, so not an actual error, just warn. */
+			}
+			env->vpid = (int) v;
+			printf_verbose("env.vpid = %d\n", env->vpid);
+		} else if (!strcmp(left, "procname")) {
+			char *right;
+
+			if (env->procname[0]) {
+				fprintf(fd, "[warning] %s: duplicated env procname\n", __func__);
+				goto error;	/* ret is 0, so not an actual error, just warn. */
+			}
+			right = concatenate_unary_strings(&node->u.ctf_expression.right);
+			if (!right) {
+				fprintf(fd, "[warning] %s: unexpected unary expression for env procname\n", __func__);
+				goto error;	/* ret is 0, so not an actual error, just warn. */
+			}
+			strncpy(env->procname, right, TRACER_ENV_LEN);
+			env->procname[TRACER_ENV_LEN - 1] = '\0';
+			printf_verbose("env.procname = %s\n", env->procname);
+		} else if (!strcmp(left, "domain")) {
+			char *right;
+
+			if (env->domain[0]) {
+				fprintf(fd, "[warning] %s: duplicated env domain\n", __func__);
+				goto error;	/* ret is 0, so not an actual error, just warn. */
+			}
+			right = concatenate_unary_strings(&node->u.ctf_expression.right);
+			if (!right) {
+				fprintf(fd, "[warning] %s: unexpected unary expression for env domain\n", __func__);
+				goto error;	/* ret is 0, so not an actual error, just warn. */
+			}
+			strncpy(env->domain, right, TRACER_ENV_LEN);
+			env->domain[TRACER_ENV_LEN - 1] = '\0';
+			printf_verbose("env.domain = %s\n", env->domain);
+		} else if (!strcmp(left, "sysname")) {
+			char *right;
+
+			if (env->sysname[0]) {
+				fprintf(fd, "[warning] %s: duplicated env sysname\n", __func__);
+				goto error;	/* ret is 0, so not an actual error, just warn. */
+			}
+			right = concatenate_unary_strings(&node->u.ctf_expression.right);
+			if (!right) {
+				fprintf(fd, "[warning] %s: unexpected unary expression for env sysname\n", __func__);
+				goto error;	/* ret is 0, so not an actual error, just warn. */
+			}
+			strncpy(env->sysname, right, TRACER_ENV_LEN);
+			env->sysname[TRACER_ENV_LEN - 1] = '\0';
+			printf_verbose("env.sysname = %s\n", env->sysname);
+		} else if (!strcmp(left, "release")) {
+			char *right;
+
+			if (env->release[0]) {
+				fprintf(fd, "[warning] %s: duplicated env release\n", __func__);
+				goto error;	/* ret is 0, so not an actual error, just warn. */
+			}
+			right = concatenate_unary_strings(&node->u.ctf_expression.right);
+			if (!right) {
+				fprintf(fd, "[warning] %s: unexpected unary expression for env release\n", __func__);
+				goto error;	/* ret is 0, so not an actual error, just warn. */
+			}
+			strncpy(env->release, right, TRACER_ENV_LEN);
+			env->release[TRACER_ENV_LEN - 1] = '\0';
+			printf_verbose("env.release = %s\n", env->release);
+		} else if (!strcmp(left, "version")) {
+			char *right;
+
+			if (env->version[0]) {
+				fprintf(fd, "[warning] %s: duplicated env version\n", __func__);
+				goto error;	/* ret is 0, so not an actual error, just warn. */
+			}
+			right = concatenate_unary_strings(&node->u.ctf_expression.right);
+			if (!right) {
+				fprintf(fd, "[warning] %s: unexpected unary expression for env version\n", __func__);
+				goto error;	/* ret is 0, so not an actual error, just warn. */
+			}
+			strncpy(env->version, right, TRACER_ENV_LEN);
+			env->version[TRACER_ENV_LEN - 1] = '\0';
+			printf_verbose("env.version = %s\n", env->version);
+		} else {
+			printf_verbose("%s: attribute \"%s\" is unknown in environment declaration.\n", __func__, left);
+		}
+
+error:
+		g_free(left);
+		break;
+	}
+	default:
+		return -EPERM;
+	}
+
+	return ret;
+}
+
 static
 int ctf_env_visit(FILE *fd, int depth, struct ctf_node *node, struct ctf_trace *trace)
 {
-	fprintf(fd, "[warning] %s: environment declaration support not implement yet.\n", __func__);
-	return 0;	/* continue */
+	int ret = 0;
+	struct ctf_node *iter;
+
+	trace->env.vpid = -1;
+	trace->env.procname[0] = '\0';
+	trace->env.domain[0] = '\0';
+	trace->env.sysname[0] = '\0';
+	trace->env.release[0] = '\0';
+	trace->env.version[0] = '\0';
+	cds_list_for_each_entry(iter, &node->u.env.declaration_list, siblings) {
+		ret = ctf_env_declaration_visit(fd, depth + 1, iter, trace);
+		if (ret)
+			goto error;
+	}
+error:
+	return 0;
 }
 
 static
@@ -2362,15 +2503,6 @@ retry:
 	switch (node->type) {
 	case NODE_ROOT:
 		if (!env_clock_done) {
-			cds_list_for_each_entry(iter, &node->u.root.env, siblings) {
-				ret = ctf_env_visit(fd, depth + 1, iter,
-						    trace);
-				if (ret) {
-					fprintf(fd, "[error] %s: env declaration error\n", __func__);
-					goto error;
-				}
-			}
-
 			/*
 			 * declarations need to query clock hash table,
 			 * so clock need to be treated first.
@@ -2414,6 +2546,13 @@ retry:
 			ret = -EINVAL;
 			goto error;
 		}
+		cds_list_for_each_entry(iter, &node->u.root.env, siblings) {
+			ret = ctf_env_visit(fd, depth + 1, iter, trace);
+			if (ret) {
+				fprintf(fd, "[error] %s: env declaration error\n", __func__);
+				goto error;
+			}
+		}
 		cds_list_for_each_entry(iter, &node->u.root.stream, siblings) {
 			ret = ctf_stream_visit(fd, depth + 1, iter,
 		    			       trace->root_declaration_scope, trace);