X-Git-Url: http://git.efficios.com/?p=babeltrace.git;a=blobdiff_plain;f=include%2Fbabeltrace%2Fctf%2Ftypes.h;h=c336632f7e6eb34b93190ae5e4d71c5f1a12d994;hp=67b24ee4aa940cf3185bff55c57c2a127b2f2904;hb=fcf104173870de4678c8f69e33039d39193c939a;hpb=0c880b0af719e4d58ccebe61acdd0e77a4479bfd

diff --git a/include/babeltrace/ctf/types.h b/include/babeltrace/ctf/types.h
index 67b24ee4..c336632f 100644
--- a/include/babeltrace/ctf/types.h
+++ b/include/babeltrace/ctf/types.h
@@ -132,6 +132,28 @@ int ctf_init_pos(struct ctf_stream_pos *pos, struct bt_trace_descriptor *trace,
 		int fd, int open_flags);
 int ctf_fini_pos(struct ctf_stream_pos *pos);
 
+static inline
+int ctf_pos_access_ok(struct ctf_stream_pos *pos, uint64_t bit_len)
+{
+	uint64_t max_len;
+
+	if (unlikely(pos->offset == EOF))
+		return 0;
+	if (pos->prot == PROT_READ) {
+		/*
+		 * Reads may only reach up to the "content_size",
+		 * regardless of the packet_size.
+		 */
+		max_len = pos->content_size;
+	} else {
+		/* Writes may take place up to the end of the packet. */
+		max_len = pos->packet_size;
+	}
+	if (unlikely(pos->offset + bit_len > max_len))
+		return 0;
+	return 1;
+}
+
 /*
  * move_pos - move position of a relative bit offset
  *
@@ -142,21 +164,17 @@ int ctf_fini_pos(struct ctf_stream_pos *pos);
 static inline
 int ctf_move_pos(struct ctf_stream_pos *pos, uint64_t bit_offset)
 {
-	uint64_t max_len;
+	int ret = 0;
 
 	printf_debug("ctf_move_pos test EOF: %" PRId64 "\n", pos->offset);
-	if (unlikely(pos->offset == EOF))
-		return 0;
-	if (pos->prot == PROT_READ)
-		max_len = pos->content_size;
-	else
-		max_len = pos->packet_size;
-	if (unlikely(pos->offset + bit_offset > max_len))
-		return 0;
-
+	ret = ctf_pos_access_ok(pos, bit_offset);
+	if (!ret) {
+		goto end;
+	}
 	pos->offset += bit_offset;
 	printf_debug("ctf_move_pos after increment: %" PRId64 "\n", pos->offset);
-	return 1;
+end:
+	return ret;
 }
 
 /*
@@ -207,22 +225,6 @@ void ctf_pos_pad_packet(struct ctf_stream_pos *pos)
 	ctf_packet_seek(&pos->parent, 0, SEEK_CUR);
 }
 
-static inline
-int ctf_pos_access_ok(struct ctf_stream_pos *pos, uint64_t bit_len)
-{
-	uint64_t max_len;
-
-	if (unlikely(pos->offset == EOF))
-		return 0;
-	if (pos->prot == PROT_READ)
-		max_len = pos->content_size;
-	else
-		max_len = pos->packet_size;
-	if (unlikely(pos->offset + bit_len > max_len))
-		return 0;
-	return 1;
-}
-
 /*
  * Update the stream position to the current event. This moves to
  * the next packet if we are located at the end of the current packet.