X-Git-Url: http://git.efficios.com/?p=babeltrace.git;a=blobdiff_plain;f=types%2Fbitfield.c;h=697748773f413b0171388b85f0315821bf402ab3;hp=a7111b1c454f81a293e4a1dc1244bdd7e0db814a;hb=bed864a75d2315c344a6e625db66ae9bfbc51e27;hpb=90b676d73fc6f817958083c0f159028a2f0b40ca diff --git a/types/bitfield.c b/types/bitfield.c index a7111b1c..69774877 100644 --- a/types/bitfield.c +++ b/types/bitfield.c @@ -22,55 +22,24 @@ #include #include -/* - * Shortcut to integer copy if we copy bit-aligned data with 0 start_offset. - * This skips the bitfield overhead when dealing with enumerations (which use - * the bitfield copy functions). - */ -extern -size_t integer_copy(unsigned char *dest, const struct format *fdest, - const unsigned char *src, const struct format *fsrc, - const struct type_class *type_class); - -size_t bitfield_copy(unsigned char *dest, const struct format *fdest, - const unsigned char *src, const struct format *fsrc, +size_t bitfield_copy(struct stream_pos *dest, const struct format *fdest, + struct stream_pos *src, const struct format *fsrc, const struct type_class *type_class) { struct type_class_bitfield *bitfield_class = container_of(type_class, struct type_class_bitfield, p); struct type_class_integer *int_class = &bitfield_class->p; - if (!(int_class->p.alignment % CHAR_BIT) - && !(int_class->len % CHAR_BIT) - && !(bitfield_class->start_offset % CHAR_BIT)) { - size_t offset = bitfield_class->start_offset / CHAR_BIT; - dest += offset; - src += offset; - return integer_copy(dest, fdest, src, fsrc, type_class); - } - if (!int_class->signedness) { uint64_t v; - v = fsrc->bitfield_unsigned_read(src, - bitfield_class->start_offset, - int_class->len, - int_class->byte_order); - return fdest->bitfield_unsigned_write(dest, - bitfield_class->start_offset, - int_class->len, int_class->byte_order, - v); + v = fsrc->bitfield_unsigned_read(src, bitfield_class); + return fdest->bitfield_unsigned_write(dest, bitfield_class, v); } else { int64_t v; - v = fsrc->bitfield_signed_read(src, - bitfield_class->start_offset, - int_class->len, - int_class->byte_order); - return fdest->bitfield_signed_write(dest, - bitfield_class->start_offset, - int_class->len, int_class->byte_order, - v); + v = fsrc->bitfield_signed_read(src, bitfield_class); + return fdest->bitfield_signed_write(dest, bitfield_class, v); } } @@ -87,7 +56,6 @@ static void _bitfield_type_free(struct type_class *type_class) } struct type_class_bitfield *bitfield_type_new(const char *name, - size_t start_offset, size_t len, int byte_order, int signedness, size_t alignment) @@ -105,7 +73,6 @@ struct type_class_bitfield *bitfield_type_new(const char *name, int_class->len = len; int_class->byte_order = byte_order; int_class->signedness = signedness; - bitfield_class->start_offset = start_offset; if (int_class->p.name) { ret = ctf_register_type(&int_class->p); if (ret) {