X-Git-Url: http://git.efficios.com/?p=babeltrace.git;a=blobdiff_plain;f=types%2Fstring.c;h=bff569db93bb11118b0904d48fcc5f1454623863;hp=796f05cd6a47f555c2584993d89956b9479adf02;hb=98b6832656447ab0f8024f9086aa67625e391ac7;hpb=0f980a3595f61930659e392b1248c59490dd5a22

diff --git a/types/string.c b/types/string.c
index 796f05cd..bff569db 100644
--- a/types/string.c
+++ b/types/string.c
@@ -3,7 +3,9 @@
  *
  * BabelTrace - String Type Converter
  *
- * Copyright 2010, 2011 - Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
+ * Copyright 2010-2011 EfficiOS Inc. and Linux Foundation
+ *
+ * Author: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
  *
  * Permission is hereby granted, free of charge, to any person obtaining a copy
  * of this software and associated documentation files (the "Software"), to deal
@@ -23,30 +25,11 @@
 static
 struct definition *_string_definition_new(struct declaration *declaration,
 				struct definition_scope *parent_scope,
-				GQuark field_name, int index);
+				GQuark field_name, int index,
+				const char *root_name);
 static
 void _string_definition_free(struct definition *definition);
 
-void string_copy(struct stream_pos *dest, const struct format *fdest, 
-		 struct stream_pos *src, const struct format *fsrc,
-		 struct definition *definition)
-{
-	struct definition_string *string =
-		container_of(definition, struct definition_string, p);
-	struct declaration_string *string_declaration = string->declaration;
-
-	if (fdest && (fsrc->string_copy == fdest->string_copy)) {
-		fsrc->string_copy(dest, src, string_declaration);
-	} else {
-		char *tmp = NULL;
-
-		fsrc->string_read(&tmp, src, string_declaration);
-		if (fdest)
-			fdest->string_write(dest, tmp, string_declaration);
-		fsrc->string_free_temp(tmp);
-	}
-}
-
 static
 void _string_declaration_free(struct declaration *declaration)
 {
@@ -63,7 +46,6 @@ struct declaration_string *
 	string_declaration = g_new(struct declaration_string, 1);
 	string_declaration->p.id = CTF_TYPE_STRING;
 	string_declaration->p.alignment = CHAR_BIT;
-	string_declaration->p.copy = string_copy;
 	string_declaration->p.declaration_free = _string_declaration_free;
 	string_declaration->p.definition_new = _string_definition_new;
 	string_declaration->p.definition_free = _string_definition_free;
@@ -76,19 +58,34 @@ static
 struct definition *
 	_string_definition_new(struct declaration *declaration,
 			       struct definition_scope *parent_scope,
-			       GQuark field_name, int index)
+			       GQuark field_name, int index,
+			       const char *root_name)
 {
 	struct declaration_string *string_declaration =
 		container_of(declaration, struct declaration_string, p);
 	struct definition_string *string;
+	int ret;
 
 	string = g_new(struct definition_string, 1);
 	declaration_ref(&string_declaration->p);
 	string->p.declaration = declaration;
 	string->declaration = string_declaration;
 	string->p.ref = 1;
-	string->p.index = index;
+	/*
+	 * Use INT_MAX order to ensure that all fields of the parent
+	 * scope are seen as being prior to this scope.
+	 */
+	string->p.index = root_name ? INT_MAX : index;
+	string->p.name = field_name;
+	string->p.path = new_definition_path(parent_scope, field_name,
+					root_name);
+	string->p.scope = NULL;
 	string->value = NULL;
+	string->len = 0;
+	string->alloc_len = 0;
+	ret = register_field_definition(field_name, &string->p,
+					parent_scope);
+	assert(!ret);
 	return &string->p;
 }
 
@@ -102,3 +99,13 @@ void _string_definition_free(struct definition *definition)
 	g_free(string->value);
 	g_free(string);
 }
+
+char *get_string(struct definition *field)
+{
+	struct definition_string *string_definition =
+		container_of(field, struct definition_string, p);
+
+	assert(string_definition->value != NULL);
+
+	return string_definition->value;
+}