Fix: sink.ctf.fs: possible uses after free because of unchecked return values
authorFrancis Deslauriers <francis.deslauriers@efficios.com>
Thu, 9 May 2019 16:02:57 +0000 (12:02 -0400)
committerJérémie Galarneau <jeremie.galarneau@efficios.com>
Tue, 14 May 2019 19:19:44 +0000 (15:19 -0400)
commit6d219f2b566b0c684ceb36beea81fc865a557804
tree2cd9aa3aeeb14397741d294b76e02465a0e27860
parentd3894100cb6365e8f263615868723efced40ab04
Fix: sink.ctf.fs: possible uses after free because of unchecked return values

Uses after free are possible because we ignore the return value of the
`bt_ctfser_write_*()` function calls. To avoid this, check the return
values and log an error message.

  CID 1401217 (#4 of 4): Use after free (USE_AFTER_FREE)
  11. deref_arg: Calling bt_ctfser_write_byte_aligned_unsigned_int
  dereferences freed pointer stream->ctfser.base_mma

  CID 1401193 (#2 of 2): Unchecked return value (CHECKED_RETURN)
  8. check_return: Calling bt_ctfser_write_byte_aligned_unsigned_int
  without checking return value (as is done elsewhere 8 out of 10
  times).

Reported-by: Coverity (1401217) Use after free
Reported-by: Coverity (1401193) Unchecked return value
Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Change-Id: I7581c0e549d7bf916f42afe306976baa9822897a
Reviewed-on: https://review.lttng.org/c/babeltrace/+/1286
Tested-by: jenkins
Reviewed-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
plugins/ctf/fs-sink/fs-sink-stream.c
This page took 0.023744 seconds and 4 git commands to generate.