Fix: src.ctf.lttng-live: omitting stream end on stream hang up
authorFrancis Deslauriers <francis.deslauriers@efficios.com>
Thu, 8 Aug 2019 17:17:40 +0000 (13:17 -0400)
committerPhilippe Proulx <eeppeliteloop@gmail.com>
Fri, 9 Aug 2019 14:34:00 +0000 (10:34 -0400)
commit4a39caef874f11e1684e67fd33ad8f86b0a6d651
tree55e6aed75b4c3f5580f322d08653323ee699e4b2
parentf1089572ca6ab9daa623a17af78bd4947850e38a
Fix: src.ctf.lttng-live: omitting stream end on stream hang up

Issue
=====
When receiving a LTTNG_VIEWER_INDEX_HUP request status, a
`src.ctf.lttng-live` component quickly removes the associated stream
iterator and move on to the next request without sending the stream end
message to properly close the stream. This breaks the guarantee that
stream end messages are always present.

Solution
========
Whenever we receive an HUP status from the server, we trigger the
`bt_msg_iter` code to hit an BT_MSG_ITER_MEDIUM_STATUS_EOF so it
generates the stream end message that closes the stream.

Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Change-Id: I89924ee95b35ca62c103651ad44c9eaf71f6df53
Reviewed-on: https://review.lttng.org/c/babeltrace/+/1840
Reviewed-by: Philippe Proulx <eeppeliteloop@gmail.com>
Tested-by: jenkins <jenkins@lttng.org>
src/plugins/ctf/lttng-live/data-stream.c
src/plugins/ctf/lttng-live/lttng-live.c
src/plugins/ctf/lttng-live/lttng-live.h
src/plugins/ctf/lttng-live/viewer-connection.c
This page took 0.025067 seconds and 4 git commands to generate.