lib/lib-logging.c: fix GCC warning: check return value of snprintf()
authorPhilippe Proulx <eeppeliteloop@gmail.com>
Tue, 9 Jul 2019 12:25:53 +0000 (08:25 -0400)
committerJérémie Galarneau <jeremie.galarneau@efficios.com>
Thu, 18 Jul 2019 15:53:34 +0000 (11:53 -0400)
commit471a33d2962fc39a82a662e965b173778c673436
tree34e161350fea77d39785d882238f5d6ec4c8ba12
parentb0e2ef083b026ef613ab90464e0f09d575263c67
lib/lib-logging.c: fix GCC warning: check return value of snprintf()

This patch fixes this GCC warning:

    lib-logging.c: In function ‘format_component’:
    lib-logging.c:110:44: error: ‘%s’ directive output may be truncated
    writing 10 bytes into a region of size between 0 and 127
    [-Werror=format-truncation=]
       snprintf(tmp_prefix, TMP_PREFIX_LEN - 1, "%s%s", \
                                                ^~~~~~
         prefix, (_prefix2));   \
                 ~~~~~~~~~~
    lib-logging.c:1013:3: note: in expansion of macro ‘SET_TMP_PREFIX’
       SET_TMP_PREFIX("so-handle-");
       ^~~~~~~~~~~~~~
    lib-logging.c:110:3: note: ‘snprintf’ output between 11 and 138
    bytes into a destination of size 127
       snprintf(tmp_prefix, TMP_PREFIX_LEN - 1, "%s%s", \
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         prefix, (_prefix2));   \
         ~~~~~~~~~~~~~~~~~~~
    lib-logging.c:1013:3: note: in expansion of macro ‘SET_TMP_PREFIX’
       SET_TMP_PREFIX("so-handle-");
       ^~~~~~~~~~~~~~

The macro aborts when the return value is unexpected, but this will
never happen as we control the prefixes internally.

Boosting the buffer's size to 128 just in case.

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Change-Id: I6cbb43de3c9ae03b5d85074d1698069084659c3b
Reviewed-on: https://review.lttng.org/c/babeltrace/+/1658
src/lib/lib-logging.c
This page took 0.025949 seconds and 4 git commands to generate.