bt2: test_message_iterator: use assertIs instead of assertTrue/assertFalse in can...
authorSimon Marchi <simon.marchi@efficios.com>
Mon, 9 Sep 2019 18:04:19 +0000 (14:04 -0400)
committerSimon Marchi <simon.marchi@efficios.com>
Tue, 17 Sep 2019 19:05:53 +0000 (15:05 -0400)
commit7f0c21bb99a20d28739bee293fa4066989b2f3d6
treeae289ec7a529c93aed49719360c4842f5e4a68e8
parent1975af3df60dddf3527b4f4af9a4686b0e7aebe8
bt2: test_message_iterator: use assertIs instead of assertTrue/assertFalse in can seek tests

In these tests, we want to specifically check that the return values are
True or False, not any value that evaluates to True or False.

For example, we initialize can_seek_beginning to None, run
graph.run_once(), then do assertFalse(can_seek_beginning).  If, for some
reason, can_seek_beginning is still None, the test will wrongfully pass.

The same could happen if can_seek_beginning gets assigned some value
that evaluates to True (other than True itself) and we use
assertTrue(can_seek_beginning).

Instead, use assertIs, which checks that the value is specifically the
one and only True or the one and only False.

Change-Id: Idf94d350ecc06cdb6a38ca31b2d77804fbf57df7
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed-on: https://review.lttng.org/c/babeltrace/+/2019
Tested-by: jenkins <jenkins@lttng.org>
Reviewed-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Reviewed-by: Philippe Proulx <eeppeliteloop@gmail.com>
tests/bindings/python/bt2/test_message_iterator.py
This page took 0.023509 seconds and 4 git commands to generate.