python-plugin-provider: Make it build
authorSimon Marchi <simon.marchi@efficios.com>
Mon, 8 Apr 2019 16:53:56 +0000 (12:53 -0400)
committerFrancis Deslauriers <francis.deslauriers@efficios.com>
Thu, 2 May 2019 20:50:15 +0000 (20:50 +0000)
commit88b3fc9c233989c30ca8e3582b4923713ec51e81
treef5fbb3489a5cf82816b65c5e06445bf343642f29
parent05c900e51aad33aff0f97191cd34bf8679e4ad3b
python-plugin-provider: Make it build

This patch fixes building with --enable-python-plugins.

One problem is that the python plugin provider uses some
functions coming from the internal headers of the lib, which use some
logging functions that are internal to the lib, but not included by
those internal headers.  Trying to add the relevant include file
(lib-logging-internal.h) conflicts with python-plugin-provider's own
logger.

python-plugin-provider doesn't really need to have its own logger.  Even
though it is built as a separate shared object (so that we can package
it separately), it can be considered as internal to the library (and
that's why it includes some internal lib headers).  Therefore, the
easiest way to fix this is to get rid of its logger and make the lib
header files that use lib logging include the required header file
(lib-logging-internal.h).

This requires the python-plugin-provider shared object to access a few
additional symbols not currently exposed by libbabeltrace, which
requires the removal of a few BT_HIDDEN.

I have also included fixes to the python-plugin-provider which I have
on hand.  However, it won't work until the Python bindings are up and
running, so I have marked it as skipped.

Change-Id: I9b46d91fc635d670fef2e4d3c8b32203ec34443f
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed-on: https://review.lttng.org/c/babeltrace/+/1101
Reviewed-by: Philippe Proulx <eeppeliteloop@gmail.com>
14 files changed:
configure.ac
include/babeltrace/lib-logging-internal.h
include/babeltrace/plugin/plugin-internal.h
include/babeltrace/plugin/plugin-so-internal.h
lib/lib-logging.c
lib/plugin/plugin-so.c
python-plugin-provider/Makefile.am
python-plugin-provider/logging.c [deleted file]
python-plugin-provider/logging.h [deleted file]
python-plugin-provider/python-plugin-provider.c
tests/python-plugin-provider/.gitignore
tests/python-plugin-provider/bt_plugin_test_python_plugin_provider.py
tests/python-plugin-provider/test_python_plugin_provider.py
tests/python-plugin-provider/test_python_plugin_provider_env.in [new file with mode: 0644]
This page took 0.026891 seconds and 4 git commands to generate.