Fix: ctf: open metadata file using mode "rb"
authorSimon Marchi <simon.marchi@efficios.com>
Tue, 1 Oct 2019 20:04:03 +0000 (16:04 -0400)
committerSimon Marchi <simon.marchi@efficios.com>
Wed, 2 Oct 2019 16:25:12 +0000 (12:25 -0400)
commit8c41c5714a2aeb9937b6b0c0cbdcb2edfb33a87e
tree5e2ad6e0de64281400db64cd260eedde90d16015
parent1376311317cd9d9a390ad758174e6340f3e3f96f
Fix: ctf: open metadata file using mode "rb"

In the handling of the support info query, we open the metadata file
using the "r" mode.  On Windows, this is a problem when opening
packetized metadata files, which may contain bytes that Windows will
treat as end of lines and transorm.  Use "rb" instead.

This makes the test_trace_copy test pass on Windows.  It currently fails
with the "session-rotation" trace.

Change-Id: Iaa7a3b8def1c07335c5e7e094d82121df56de268
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed-on: https://review.lttng.org/c/babeltrace/+/2110
Tested-by: jenkins <jenkins@lttng.org>
Reviewed-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Reviewed-by: Michael Jeanson <mjeanson@efficios.com>
src/plugins/ctf/fs-src/query.c
This page took 0.025826 seconds and 4 git commands to generate.