Fix: uninitialized variant fc in set_field_refs()

GCC 8.3.0 emits the following warning:

translate-trace-ir-to-ctf-ir.c:935:16: warning: ‘var_fc’ may be used
uninitialized in this function [-Wmaybe-uninitialized]
     named_fc =
     fs_sink_ctf_field_class_variant_borrow_option_by_index(
                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
		           var_fc, i);

I don't think this "condition" is reachable, but it is, in principle
possible. Initializing var_fc to NULL silences this warning.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Change-Id: I1fd8951778e8b3705974324e1cd5d87892c2e418
Reviewed-on: https://review.lttng.org/c/babeltrace/+/1251
Reviewed-by: Francis Deslauriers <francis.deslauriers@efficios.com>

diff --git a/plugins/ctf/fs-sink/translate-trace-ir-to-ctf-ir.c b/plugins/ctf/fs-sink/translate-trace-ir-to-ctf-ir.c
index 4d740139c8e62973eb9b47495b0b7bf2532c8c19..699b3a5b620d9bb6abb81994704285662f6819f6 100644 (file)
--- a/plugins/ctf/fs-sink/translate-trace-ir-to-ctf-ir.c
+++ b/plugins/ctf/fs-sink/translate-trace-ir-to-ctf-ir.c
@@ -912,7 +912,7 @@ int set_field_refs(struct fs_sink_ctf_field_class * const fc,
                uint64_t i;
                uint64_t len;
                struct fs_sink_ctf_field_class_struct *struct_fc;
-               struct fs_sink_ctf_field_class_variant *var_fc;
+               struct fs_sink_ctf_field_class_variant *var_fc = NULL;
                struct fs_sink_ctf_named_field_class *named_fc;
 
                if (fc_type == FS_SINK_CTF_FIELD_CLASS_TYPE_STRUCT) {