Annotate implicit fall-through

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Change-Id: I21c5641869afca1fcac301f612d02d2cb10583db
Reviewed-on: https://review.lttng.org/c/babeltrace/+/1293
Reviewed-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

diff --git a/common/common.c b/common/common.c
index de98e34cf7636f32a2df43c3afb41abce510c98b..68f537ba0187c08f0f5bfc89fdf83df6babe8d20 100644 (file)
--- a/common/common.c
+++ b/common/common.c
@@ -822,7 +822,7 @@ void bt_common_normalize_star_glob_pattern(char *pattern)
                                goto end;
                        }
 
-                       /* Fall through default case. */
+                       /* fall-through */
                default:
                        got_star = false;
                        break;
@@ -1042,6 +1042,7 @@ retry:
                         * Fall through the default case which compares
                         * the escaped character now.
                         */
+                       /* fall-through */
                default:
                        if (at_end_of_pattern(p, pattern, pattern_len) ||
                                        *c != *p) {

diff --git a/plugins/ctf/common/metadata/ctf-meta-warn-meaningless-header-fields.c b/plugins/ctf/common/metadata/ctf-meta-warn-meaningless-header-fields.c
index 943078ffa13186b48561da11480989eccfd9dea2..3abc7c9b459f4301fcb8440bdb5dc6f08a222589 100644 (file)
--- a/plugins/ctf/common/metadata/ctf-meta-warn-meaningless-header-fields.c
+++ b/plugins/ctf/common/metadata/ctf-meta-warn-meaningless-header-fields.c
@@ -97,8 +97,8 @@ void warn_meaningless_fields(struct ctf_field_class *fc, const char *name,
                        goto end;
                }
 
-               /* Fallthrough */
        }
+       /* fall-through */
        case CTF_FIELD_CLASS_TYPE_SEQUENCE:
        {
                struct ctf_field_class_array_base *array_fc = (void *) fc;

diff --git a/plugins/ctf/common/metadata/parser.y b/plugins/ctf/common/metadata/parser.y
index 2151f75d336afc8fa645df8e1912f5cee164fa2b..504b2b28406bb77628110b1b4ff6b1934f58be18 100644 (file)
--- a/plugins/ctf/common/metadata/parser.y
+++ b/plugins/ctf/common/metadata/parser.y
@@ -883,11 +883,13 @@ static int set_parent_node(struct ctf_node *node,
                        parent->u.field_class_alias.target = node;
                else
                        return -EINVAL;
+               /* fall-through */
        case NODE_TYPEALIAS_ALIAS:
                if (parent->type == NODE_TYPEALIAS)
                        parent->u.field_class_alias.alias = node;
                else
                        return -EINVAL;
+               /* fall-through */
        case NODE_TYPEALIAS:
                return reparent_field_class_alias(node, parent);