Fix: Undefined behavior of double free on strlist in get_names_args

Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

diff --git a/converter/babeltrace.c b/converter/babeltrace.c
index 20ded00495e9e7262a32677088231ab512c04482..ed19fa85a5b0fd59baa958be6f5eb3a8ef45d096 100644 (file)
--- a/converter/babeltrace.c
+++ b/converter/babeltrace.c
@@ -204,7 +204,6 @@ static int get_names_args(poptContext *pc)
                        opt_payload_field_names = 0;
                } else {
                        fprintf(stderr, "[error] unknown field name type %s\n", str);
                        opt_payload_field_names = 0;
                } else {
                        fprintf(stderr, "[error] unknown field name type %s\n", str);

-                       free(strlist);

                        ret = -EINVAL;
                        goto end;
                }
                        ret = -EINVAL;
                        goto end;
                }