Fix babeltrace-log uninitialized memory
authorHui Zhu <teawater@gmail.com>
Fri, 7 Sep 2012 12:36:28 +0000 (08:36 -0400)
committerMathieu Desnoyers <mathieu.desnoyers@efficios.com>
Fri, 7 Sep 2012 12:36:28 +0000 (08:36 -0400)
Got a crash with babeltrace-log.

../../../babeltrace/include/babeltrace/mmap-align.h:78
index=0, whence=0)
    at ../../../babeltrace/formats/ctf/ctf.c:623
    at ../../../babeltrace/formats/ctf/ctf.c:576
<_IO_2_1_stdin_>)
    at ../../babeltrace/converter/babeltrace-log.c:233
../../babeltrace/converter/babeltrace-log.c:342

This issue because pos is used before it init.  This patch init it in
function ctf_init_pos.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
formats/ctf/ctf.c

index f43fe91789d21d109c0adf407a0b7e951201ca39..d4ff2a52267be7d2a00d2428bd7b42a068875a01 100644 (file)
@@ -550,6 +550,7 @@ error:
 
 void ctf_init_pos(struct ctf_stream_pos *pos, int fd, int open_flags)
 {
+       memset(pos, 0, sizeof(*pos));
        pos->fd = fd;
        if (fd >= 0) {
                pos->packet_cycles_index = g_array_new(FALSE, TRUE,
This page took 0.033756 seconds and 4 git commands to generate.