tests: quote ${BT_CTF_TRACES_PATH} in test_trace_read and test_trace_copy
authorSimon Marchi <simon.marchi@efficios.com>
Wed, 20 Nov 2019 16:15:30 +0000 (11:15 -0500)
committerSimon Marchi <simon.marchi@efficios.com>
Wed, 20 Nov 2019 19:04:09 +0000 (14:04 -0500)
Fixes these shellcheck errors:

    In test_trace_copy line 33:
    SUCCESS_TRACES=(${BT_CTF_TRACES_PATH}/succeed/*)
                    ^-------------------^ SC2206: Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.

    In test_trace_read line 29:
    SUCCESS_TRACES=(${BT_CTF_TRACES_PATH}/succeed/*)
                    ^-------------------^ SC2206: Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.

    In test_trace_read line 30:
    FAIL_TRACES=(${BT_CTF_TRACES_PATH}/fail/*)
                 ^-------------------^ SC2206: Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.

Reported-by: shellcheck
Change-Id: Ia13810be69d2bc57f6d6541887de0f9d75e3ffe5
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed-on: https://review.lttng.org/c/babeltrace/+/2417
Tested-by: jenkins <jenkins@lttng.org>
tests/cli/test_trace_copy
tests/cli/test_trace_read

index 15b1344b310179ed7b77979805f39b034ce0080f..5f902e17848d088a5f392d3ef9e16d170e11c3df 100755 (executable)
@@ -30,7 +30,7 @@ clean_tmp() {
        rm -rf "${out_path}" "${text_output1}" "${text_output2_intermediary}" "${text_output2}"
 }
 
-SUCCESS_TRACES=(${BT_CTF_TRACES_PATH}/succeed/*)
+SUCCESS_TRACES=("${BT_CTF_TRACES_PATH}/succeed/"*)
 
 # -2 because there is an empty trace that we skip
 NUM_TESTS=$((${#SUCCESS_TRACES[@]} * 3 - 2))
index 5dd9c3db54d42507baf222abc43fdeb1e15c56bd..e0ad90c2e81348dbbc5698c44a4fcfb79ccfc77b 100755 (executable)
@@ -26,8 +26,8 @@ fi
 # shellcheck source=../utils/utils.sh
 source "$UTILSSH"
 
-SUCCESS_TRACES=(${BT_CTF_TRACES_PATH}/succeed/*)
-FAIL_TRACES=(${BT_CTF_TRACES_PATH}/fail/*)
+SUCCESS_TRACES=("${BT_CTF_TRACES_PATH}/succeed/"*)
+FAIL_TRACES=("${BT_CTF_TRACES_PATH}/fail/"*)
 
 NUM_TESTS=$((${#SUCCESS_TRACES[@]} + ${#FAIL_TRACES[@]}))
 
This page took 0.024984 seconds and 4 git commands to generate.