Fix: respect signed integers' length when printing in hex base

Make sure we don't print a full 64-bit sign-extended value
when printing a negative integer in hexadecimal base.

Fixes #848

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

diff --git a/formats/ctf-text/types/integer.c b/formats/ctf-text/types/integer.c
index 7363b524e6f1b9af5d896cd55630bcb3990b7c0c..9602a902a766d8673a14e8896ee91bc59e3d34e7 100644 (file)
--- a/formats/ctf-text/types/integer.c
+++ b/formats/ctf-text/types/integer.c
@@ -112,10 +112,15 @@ int ctf_text_integer_write(struct bt_stream_pos *ppos, struct bt_definition *def
        {
                uint64_t v;
 
-               if (!integer_declaration->signedness)
+               if (!integer_declaration->signedness) {
                        v = integer_definition->value._unsigned;
-               else
+               } else {
+                       /* Round length to the nearest nibble */
+                       uint8_t rounded_len = ((integer_declaration->len + 3) & ~0x3);
+
                        v = (uint64_t) integer_definition->value._signed;
+                       v &= ((uint64_t) 1 << rounded_len) - 1;
+               }
 
                fprintf(pos->fp, "0x%" PRIX64, v);
                break;