Fix -Wsuggest-attribute warnings

plan_skip_all unconditionally exits, so it can be marked as noreturn.

Fixes:

  CC       tap.lo
/home/smarchi/src/babeltrace/tests/utils/tap/tap.c: In function ‘plan_skip_all’:
/home/smarchi/src/babeltrace/tests/utils/tap/tap.c:231:1: error: function might be candidate for attribute ‘noreturn’ [-Werror=suggest-attribute=noreturn]
 plan_skip_all(const char *reason)
 ^~~~~~~~~~~~~

Change-Id: I740aa065c888c53a7be880a9e6e68e6f12b1d42d
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed-on: https://review.lttng.org/c/babeltrace/+/2259
Tested-by: jenkins <jenkins@lttng.org>
Reviewed-by: Francis Deslauriers <francis.deslauriers@efficios.com>

diff --git a/configure.ac b/configure.ac
index 9f4f27d1a025c502bbd740c7d6170ef9e280f077..7c6875234113802e43d8c248f93a442838d87208 100644 (file)
--- a/configure.ac
+++ b/configure.ac
@@ -682,7 +682,6 @@ AX_COMPILER_FLAGS(
                -Wno-missing-include-dirs dnl
                -Wno-duplicated-cond dnl
                -Wno-double-promotion dnl
-               -Wno-suggest-attribute=noreturn dnl
                -Wno-cast-align dnl
        ])
 

diff --git a/tests/utils/tap/tap.h b/tests/utils/tap/tap.h
index c653076db09da2741a828bb1e63c91c0a6baa297..0d6e66870fb924b6326349bff5f1e418f5c73677 100644 (file)
--- a/tests/utils/tap/tap.h
+++ b/tests/utils/tap/tap.h
@@ -84,6 +84,7 @@ __attribute__((format(TAP_PRINTF_FORMAT, 5, 6)))
 unsigned int _gen_result(int, const char *, const char *, unsigned int, const char *, ...);
 
 int plan_no_plan(void);
+__attribute__((noreturn))
 int plan_skip_all(const char *);
 int plan_tests(unsigned int);