From: Simon Marchi <simon.marchi@efficios.com>
Date: Tue, 22 Oct 2019 15:16:58 +0000 (-0400)
Subject: lib: remove includes from logging.h
X-Git-Tag: v2.0.0-rc2~64
X-Git-Url: http://git.efficios.com/?p=babeltrace.git;a=commitdiff_plain;h=109730d9c5fe6172f409fb5b3fb96d48f9adf786

lib: remove includes from logging.h

Nothing in logging.h uses anything from those includes.

Removing them causes this failure in py-common.c:

  CC       py-common.lo
In file included from /home/smarchi/src/babeltrace/src/py-common/py-common.c:32:0:
/home/smarchi/src/babeltrace/src/py-common/py-common.h:44:18: error: unknown type name ‘bool’; did you mean ‘_Bool’?
   int log_level, bool chain);
                  ^~~~
                  _Bool

Doing this change revealed a few files that were using bool without
including stdbool.h, add the includes there.

Change-Id: Ica802312a21c2a28cfaa1011d0034f0d1f65594e
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed-on: https://review.lttng.org/c/babeltrace/+/2241
Tested-by: jenkins <jenkins@lttng.org>
Reviewed-by: Francis Deslauriers <francis.deslauriers@efficios.com>
---

diff --git a/include/babeltrace2/logging.h b/include/babeltrace2/logging.h
index ae03d8d1..37143e19 100644
--- a/include/babeltrace2/logging.h
+++ b/include/babeltrace2/logging.h
@@ -27,10 +27,6 @@
 # error "Please include <babeltrace2/babeltrace.h> instead."
 #endif
 
-#include <stdint.h>
-#include <stdbool.h>
-#include <stddef.h>
-
 #ifdef __cplusplus
 extern "C" {
 #endif
diff --git a/src/cli/babeltrace2-plugins.c b/src/cli/babeltrace2-plugins.c
index 0093d4ce..42cda686 100644
--- a/src/cli/babeltrace2-plugins.c
+++ b/src/cli/babeltrace2-plugins.c
@@ -27,6 +27,7 @@
 
 #include "babeltrace2-plugins.h"
 
+#include <stdbool.h>
 #include <babeltrace2/babeltrace.h>
 
 /* Array of bt_plugin * */
diff --git a/src/plugins/common/param-validation/param-validation.h b/src/plugins/common/param-validation/param-validation.h
index a78f997b..3113ff4d 100644
--- a/src/plugins/common/param-validation/param-validation.h
+++ b/src/plugins/common/param-validation/param-validation.h
@@ -25,6 +25,7 @@
 
 #include <babeltrace2/babeltrace.h>
 #include <glib.h>
+#include <stdbool.h>
 
 #include <stdio.h> /* For __MINGW_PRINTF_FORMAT. */
 
diff --git a/src/py-common/py-common.h b/src/py-common/py-common.h
index 27a3a619..6622438a 100644
--- a/src/py-common/py-common.h
+++ b/src/py-common/py-common.h
@@ -27,6 +27,7 @@
 
 #include <glib.h>
 #include <Python.h>
+#include <stdbool.h>
 
 #include "common/macros.h"