From: Philippe Proulx Date: Fri, 9 Aug 2019 19:00:35 +0000 (-0400) Subject: Fix: dmesg.c: deference before `NULL` check X-Git-Url: http://git.efficios.com/?p=babeltrace.git;a=commitdiff_plain;h=53265bca06ff4206bdaa9935919e66ab46a006c8 Fix: dmesg.c: deference before `NULL` check Found by Coverity Scan. Signed-off-by: Philippe Proulx Change-Id: I841e1434341037ddf482445464c3fd428f08edd7 --- diff --git a/src/plugins/text/dmesg/dmesg.c b/src/plugins/text/dmesg/dmesg.c index e8317d47..7fa50720 100644 --- a/src/plugins/text/dmesg/dmesg.c +++ b/src/plugins/text/dmesg/dmesg.c @@ -634,12 +634,14 @@ end: static void destroy_dmesg_msg_iter(struct dmesg_msg_iter *dmesg_msg_iter) { - struct dmesg_component *dmesg_comp = dmesg_msg_iter->dmesg_comp; + struct dmesg_component *dmesg_comp; if (!dmesg_msg_iter) { return; } + dmesg_comp = dmesg_msg_iter->dmesg_comp; + if (dmesg_msg_iter->fp && dmesg_msg_iter->fp != stdin) { if (fclose(dmesg_msg_iter->fp)) { BT_COMP_LOGE_ERRNO("Cannot close input file", ".");