From: Mathieu Desnoyers Date: Wed, 26 Jul 2017 18:08:02 +0000 (-0400) Subject: Cleanup: remove logically dead code X-Git-Url: http://git.efficios.com/?p=babeltrace.git;a=commitdiff_plain;h=7401e2d1ffcf2e41031b3a7f3e3ba9ff158876c9 Cleanup: remove logically dead code Found by Coverity: dead_error_condition: The condition ret == BT_NOTIFICATION_ITERATOR_STATUS_OK cannot be true. 206 if (ret == BT_NOTIFICATION_ITERATOR_STATUS_OK) { CID 1376170 (#1 of 1): Logically dead code (DEADCODE)dead_error_line: Execution cannot reach this statement: ret = BT_NOTIFICATION_ITERA.... Signed-off-by: Mathieu Desnoyers Signed-off-by: Jérémie Galarneau --- diff --git a/plugins/ctf/fs-src/fs.c b/plugins/ctf/fs-src/fs.c index 12099ec4..7cbd28f8 100644 --- a/plugins/ctf/fs-src/fs.c +++ b/plugins/ctf/fs-src/fs.c @@ -193,7 +193,7 @@ enum bt_notification_iterator_status ctf_fs_iterator_init( } ret = bt_private_notification_iterator_set_user_data(it, notif_iter_data); - if (ret) { + if (ret != BT_NOTIFICATION_ITERATOR_STATUS_OK) { goto error; } @@ -203,10 +203,6 @@ enum bt_notification_iterator_status ctf_fs_iterator_init( error: (void) bt_private_notification_iterator_set_user_data(it, NULL); - if (ret == BT_NOTIFICATION_ITERATOR_STATUS_OK) { - ret = BT_NOTIFICATION_ITERATOR_STATUS_ERROR; - } - end: ctf_fs_notif_iter_data_destroy(notif_iter_data); return ret;