From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Date: Wed, 26 Jul 2017 17:23:47 +0000 (-0400)
Subject: Fix: wrong variable in NULL check
X-Git-Url: http://git.efficios.com/?p=babeltrace.git;a=commitdiff_plain;h=9270b61e78604bf36ccf3c7f12eb045a8fe6832e

Fix: wrong variable in NULL check

Found by Coverity:

notnull: At condition impl_args, the value of impl_args cannot be NULL.
dead_error_condition: The condition !impl_args cannot be true.

CID 1376172 (#1 of 1): Logically dead code (DEADCODE)dead_error_begin:
Execution cannot reach this statement: print_err_oom();.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
---

diff --git a/cli/babeltrace-cfg-cli-args.c b/cli/babeltrace-cfg-cli-args.c
index 2978ab48..b48c6967 100644
--- a/cli/babeltrace-cfg-cli-args.c
+++ b/cli/babeltrace-cfg-cli-args.c
@@ -3553,7 +3553,7 @@ int fill_implicit_ctf_inputs_args(GPtrArray *implicit_ctf_inputs_args,
 		BT_PUT(impl_args->extra_params);
 		impl_args->extra_params =
 			bt_value_copy(base_implicit_ctf_input_args->extra_params);
-		if (!impl_args) {
+		if (!impl_args->extra_params) {
 			print_err_oom();
 			destroy_implicit_component_args(impl_args);
 			goto error;