From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Date: Thu, 8 Mar 2012 21:41:32 +0000 (-0500)
Subject: API fix: Move ctf iterator API members to new babeltrace/ctf/iterator.h
X-Git-Tag: v1.0.0-pre4~13
X-Git-Url: http://git.efficios.com/?p=babeltrace.git;a=commitdiff_plain;h=9efd5d766ca00e09bc527a7d75705ac5e2d923d7

API fix: Move ctf iterator API members to new babeltrace/ctf/iterator.h

They did not belong in babeltrace/ctf/event.h.

(Closes #161)

Reported-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
---

diff --git a/converter/babeltrace.c b/converter/babeltrace.c
index 6905070a..54efdfe0 100644
--- a/converter/babeltrace.c
+++ b/converter/babeltrace.c
@@ -25,6 +25,7 @@
 #include <babeltrace/context.h>
 #include <babeltrace/ctf/types.h>
 #include <babeltrace/ctf/events.h>
+#include <babeltrace/ctf/iterator.h>
 #include <babeltrace/ctf-text/types.h>
 #include <babeltrace/iterator.h>
 #include <popt.h>
diff --git a/include/Makefile.am b/include/Makefile.am
index 24826263..1fb0b577 100644
--- a/include/Makefile.am
+++ b/include/Makefile.am
@@ -8,8 +8,9 @@ babeltraceinclude_HEADERS = \
 	babeltrace/list.h
 
 babeltracectfinclude_HEADERS = \
-       babeltrace/ctf/events.h \
-       babeltrace/ctf/callbacks.h
+	babeltrace/ctf/events.h \
+	babeltrace/ctf/callbacks.h \
+	babeltrace/ctf/iterator.h
 
 noinst_HEADERS = \
 	babeltrace/align.h \
diff --git a/include/babeltrace/ctf/events.h b/include/babeltrace/ctf/events.h
index a08518b8..d0ec3e10 100644
--- a/include/babeltrace/ctf/events.h
+++ b/include/babeltrace/ctf/events.h
@@ -24,12 +24,10 @@
  */
 
 #include <stdint.h>
-#include <babeltrace/iterator.h>
 
 struct ctf_stream;
 struct ctf_stream_event;
 struct definition;
-struct bt_ctf_iter;
 
 /*
  * the top-level scopes in CTF
@@ -78,42 +76,6 @@ struct bt_ctf_event {
 	struct ctf_stream_event *event;
 };
 
-/*
- * bt_ctf_iter_read_event: Read the iterator's current event data.
- *
- * @iter: trace collection iterator (input)
- * @stream: stream containing event at current position (output)
- * @event: current event (output)
- * Return 0 on success, negative error value on error.
- */
-struct bt_ctf_event *bt_ctf_iter_read_event(struct bt_ctf_iter *iter);
-
-/*
- * bt_ctf_iter_create - Allocate a CTF trace collection iterator.
- *
- * begin_pos and end_pos are optional parameters to specify the position
- * at which the trace collection should be seeked upon iterator
- * creation, and the position at which iteration will start returning
- * "EOF".
- *
- * By default, if begin_pos is NULL, a BT_SEEK_CUR is performed at
- * creation. By default, if end_pos is NULL, a BT_SEEK_END (end of
- * trace) is the EOF criterion.
- */
-struct bt_ctf_iter *bt_ctf_iter_create(struct bt_context *ctx,
-		struct bt_iter_pos *begin_pos,
-		struct bt_iter_pos *end_pos);
-
-/*
- * bt_ctf_get_iter - get iterator from ctf iterator.
- */
-struct bt_iter *bt_ctf_get_iter(struct bt_ctf_iter *iter);
-
-/*
- * bt_ctf_iter_destroy - Free a CTF trace collection iterator.
- */
-void bt_ctf_iter_destroy(struct bt_ctf_iter *iter);
-
 /*
  * bt_ctf_get_top_level_scope: return a definition of the top-level scope
  *