From: Simon Marchi <simon.marchi@efficios.com>
Date: Tue, 24 Sep 2019 18:33:16 +0000 (-0400)
Subject: Fix: bt2: unused assignments in test_field_class.py
X-Git-Tag: v2.0.0-rc1~97
X-Git-Url: http://git.efficios.com/?p=babeltrace.git;a=commitdiff_plain;h=c82e51226e96a92c8321c22f9c2a672d6c5b93d3

Fix: bt2: unused assignments in test_field_class.py

Fix these:

    ./tests/bindings/python/bt2/test_field_class.py:101:9: F841 local variable 'field' is assigned to but never used
    ./tests/bindings/python/bt2/test_field_class.py:124:9: F841 local variable 'field' is assigned to but never used
    ./tests/bindings/python/bt2/test_field_class.py:215:9: F841 local variable 'field' is assigned to but never used
    ./tests/bindings/python/bt2/test_field_class.py:234:9: F841 local variable 'field' is assigned to but never used
    ./tests/bindings/python/bt2/test_field_class.py:251:9: F841 local variable 'field' is assigned to but never used
    ./tests/bindings/python/bt2/test_field_class.py:402:9: F841 local variable 'field' is assigned to but never used
    ./tests/bindings/python/bt2/test_field_class.py:428:9: F841 local variable 'field' is assigned to but never used
    ./tests/bindings/python/bt2/test_field_class.py:445:9: F841 local variable 'field' is assigned to but never used
    ./tests/bindings/python/bt2/test_field_class.py:1183:9: F841 local variable 'field' is assigned to but never used
    ./tests/bindings/python/bt2/test_field_class.py:1222:9: F841 local variable 'field' is assigned to but never used

In all these cases, the assignment has no effect.  The original intent
was probably to do `field.value = ...`, so use that everywhere.

Reported-by: flake8
Change-Id: If28fab3d1a8facb0123ab3a2dc0b83062ebed38e
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed-on: https://review.lttng.org/c/babeltrace/+/2089
---

diff --git a/tests/bindings/python/bt2/test_field_class.py b/tests/bindings/python/bt2/test_field_class.py
index 01c1a46a..c1a7afbc 100644
--- a/tests/bindings/python/bt2/test_field_class.py
+++ b/tests/bindings/python/bt2/test_field_class.py
@@ -98,7 +98,7 @@ class _TestFieldClass:
 class BoolFieldClassTestCase(_TestFieldClass, unittest.TestCase):
     @staticmethod
     def _const_value_setter(field):
-        field = False
+        field.value = False
 
     def _create_default_field_class(self, **kwargs):
         tc = get_default_trace_class()
@@ -121,7 +121,7 @@ class BoolFieldClassTestCase(_TestFieldClass, unittest.TestCase):
 class BitArrayFieldClassTestCase(_TestFieldClass, unittest.TestCase):
     @staticmethod
     def _const_value_setter(field):
-        field = []
+        field.value = []
 
     def _create_field_class(self, *args, **kwargs):
         tc = get_default_trace_class()
@@ -212,7 +212,7 @@ class SignedIntegerFieldClassTestCase(
 ):
     @staticmethod
     def _const_value_setter(field):
-        field = -18
+        field.value = -18
 
     def _create_field_class(self, *args, **kwargs):
         tc = get_default_trace_class()
@@ -231,7 +231,7 @@ class UnsignedIntegerFieldClassTestCase(
 ):
     @staticmethod
     def _const_value_setter(field):
-        field = 18
+        field.value = 18
 
     def _create_field_class(self, *args, **kwargs):
         tc = get_default_trace_class()
@@ -248,7 +248,7 @@ class UnsignedIntegerFieldClassTestCase(
 class RealFieldClassTestCase(_TestFieldClass, unittest.TestCase):
     @staticmethod
     def _const_value_setter(field):
-        field = -18
+        field.value = -18
 
     def _create_field_class(self, *args, **kwargs):
         tc = get_default_trace_class()
@@ -399,7 +399,7 @@ class UnsignedEnumerationFieldClassTestCase(
 
     @staticmethod
     def _const_value_setter(field):
-        field = 0
+        field.value = 0
 
     def _create_field_class(self, *args, **kwargs):
         tc = get_default_trace_class()
@@ -425,7 +425,7 @@ class SignedEnumerationFieldClassTestCase(
 
     @staticmethod
     def _const_value_setter(field):
-        field = 0
+        field.value = 0
 
     def _create_field_class(self, *args, **kwargs):
         tc = get_default_trace_class()
@@ -442,7 +442,7 @@ class SignedEnumerationFieldClassTestCase(
 class StringFieldClassTestCase(_TestFieldClass, unittest.TestCase):
     @staticmethod
     def _const_value_setter(field):
-        field = 'chaine'
+        field.value = 'chaine'
 
     def _create_field_class(self, *args, **kwargs):
         tc = get_default_trace_class()
@@ -1180,7 +1180,7 @@ class _ArrayFieldClassTestCase:
 class StaticArrayFieldClassTestCase(_ArrayFieldClassTestCase, unittest.TestCase):
     @staticmethod
     def _const_value_setter(field):
-        field = []
+        field.value = [9] * 45
 
     def _create_array(self):
         return self._tc.create_static_array_field_class(self._elem_fc, 45)
@@ -1219,7 +1219,7 @@ class StaticArrayFieldClassTestCase(_ArrayFieldClassTestCase, unittest.TestCase)
 class DynamicArrayFieldClassTestCase(_ArrayFieldClassTestCase, unittest.TestCase):
     @staticmethod
     def _const_value_setter(field):
-        field = []
+        field.value = []
 
     def _create_array(self):
         return self._tc.create_dynamic_array_field_class(self._elem_fc)