From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Date: Wed, 4 Dec 2013 16:09:16 +0000 (+0100)
Subject: Be more widely accepting for missing variant/enum fields
X-Git-Tag: v1.2.0-rc1~34
X-Git-Url: http://git.efficios.com/?p=babeltrace.git;a=commitdiff_plain;h=d80f08379f65bcb7eb3af1f8be6d7b3f66f4e830;ds=sidebyside

Be more widely accepting for missing variant/enum fields

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
---

diff --git a/types/variant.c b/types/variant.c
index 1f0dc6aa..3641fa05 100644
--- a/types/variant.c
+++ b/types/variant.c
@@ -124,53 +124,6 @@ struct declaration_variant *
 	return variant_declaration;
 }
 
-/*
- * tag_instance is assumed to be an enumeration.
- * Returns 0 if OK, < 0 if error.
- */
-static
-int check_enum_tag(struct definition_variant *variant,
-		   struct bt_definition *enum_tag)
-{
-	struct definition_enum *_enum =
-		container_of(enum_tag, struct definition_enum, p);
-	struct declaration_enum *enum_declaration = _enum->declaration;
-	int missing_field = 0;
-	unsigned long i;
-
-	/*
-	 * Strictly speaking, each enumerator must map to a field of the
-	 * variant. However, we are even stricter here by requiring that each
-	 * variant choice map to an enumerator too. We then validate that the
-	 * number of enumerators equals the number of variant choices.
-	 */
-	if (variant->declaration->untagged_variant->fields->len != bt_enum_get_nr_enumerators(enum_declaration))
-		return -EPERM;
-
-	for (i = 0; i < variant->declaration->untagged_variant->fields->len; i++) {
-		struct declaration_field *field_declaration =
-			&g_array_index(variant->declaration->untagged_variant->fields,
-				       struct declaration_field, i);
-		if (!bt_enum_quark_to_range_set(enum_declaration, field_declaration->name)) {
-			missing_field = 1;
-			break;
-		}
-	}
-	if (missing_field)
-		return -EPERM;
-
-	/*
-	 * Check the enumeration: it must map each value to one and only one
-	 * enumerator tag.
-	 * TODO: we should also check that each range map to one and only one
-	 * tag. For the moment, we will simply check this dynamically in
-	 * variant_declaration_get_current_field().
-	 */
-	return 0;
-}
-
-
-
 static
 struct bt_definition *
 	_variant_definition_new(struct bt_declaration *declaration,
@@ -206,8 +159,7 @@ struct bt_definition *
 						   variant_declaration->tag_name,
 						   parent_scope);
 					      
-	if (!variant->enum_tag
-	    || check_enum_tag(variant, variant->enum_tag) < 0)
+	if (!variant->enum_tag)
 		goto error;
 	bt_definition_ref(variant->enum_tag);
 	variant->fields = g_ptr_array_sized_new(variant_declaration->untagged_variant->fields->len);