From: Simon Marchi Date: Tue, 24 Sep 2019 16:34:51 +0000 (-0400) Subject: bt2: remove duplicate test test_create_from_vint in RealValueTestCase X-Git-Url: http://git.efficios.com/?p=babeltrace.git;a=commitdiff_plain;h=d81716f0e4a89e270db71c42a5f9ae6e9704a8ee bt2: remove duplicate test test_create_from_vint in RealValueTestCase There are two tests named like this in RealValueTestCase. The second one looks right (it creates a Value from an int, then creates a RealValue from that). The first one looks like it should be called "test_create_from_vfloat", as it tests creating a RealValue from another RealValue, but we already have such a test case a bit lower. So I think it's fine to delete it. Reported-by: flake8 Change-Id: I274b922c653675913f2346cbc67cbcd03cd5208f Signed-off-by: Simon Marchi Reviewed-on: https://review.lttng.org/c/babeltrace/+/2086 Reviewed-by: Francis Deslauriers --- diff --git a/tests/bindings/python/bt2/test_value.py b/tests/bindings/python/bt2/test_value.py index a2fbd6c2..87f624b2 100644 --- a/tests/bindings/python/bt2/test_value.py +++ b/tests/bindings/python/bt2/test_value.py @@ -1363,10 +1363,6 @@ class RealValueTestCase(_TestNumericValue, unittest.TestCase): def test_create_neg(self): self.assertEqual(self._fn, self._nv) - def test_create_from_vint(self): - f = bt2.RealValue(self._fp) - self.assertEqual(f, self._pv) - def test_create_from_false(self): f = bt2.RealValue(False) self.assertFalse(f)