From: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Date: Tue, 7 Mar 2023 18:59:39 +0000 (-0500)
Subject: error.c: clean-up: remove dead error cause clean-up code
X-Git-Url: http://git.efficios.com/?p=babeltrace.git;a=commitdiff_plain;h=f8b833e602f434d14bf8b7b87f876e91c4b6767f

error.c: clean-up: remove dead error cause clean-up code

Coverity warns of logically dead code in error.c:
  1506395 Logically dead code
  The indicated dead code may have performed some action; that action will never occur.

  In bt_error_append_cause_from_component_class: Code can never be reached because of a logical contradiction (CWE-561)

`cause` is indeed always NULL at the `end` label since it either failed
to be allocated or its ownership was transferred to the `causes` array.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Change-Id: Ie1c746b9fe6d6202cd6c3baaef39516a5e902471
Reviewed-on: https://review.lttng.org/c/babeltrace/+/9614
Reviewed-by: Simon Marchi <simon.marchi@efficios.com>
Tested-by: jenkins <jenkins@lttng.org>
---

diff --git a/src/lib/error.c b/src/lib/error.c
index 067f30db..149579f4 100644
--- a/src/lib/error.c
+++ b/src/lib/error.c
@@ -494,7 +494,6 @@ int bt_error_append_cause_from_unknown(struct bt_error *error,
 	cause = NULL;
 
 end:
-	destroy_error_cause(cause);
 	return status;
 }
 
@@ -527,10 +526,6 @@ int bt_error_append_cause_from_component(
 	cause = NULL;
 
 end:
-	if (cause) {
-		destroy_error_cause(&cause->base);
-	}
-
 	return status;
 }
 
@@ -564,10 +559,6 @@ int bt_error_append_cause_from_component_class(
 	cause = NULL;
 
 end:
-	if (cause) {
-		destroy_error_cause(&cause->base);
-	}
-
 	return status;
 }
 
@@ -600,10 +591,6 @@ int bt_error_append_cause_from_message_iterator(
 	cause = NULL;
 
 end:
-	if (cause) {
-		destroy_error_cause(&cause->base);
-	}
-
 	return status;
 }