babeltrace.git
9 years agoFix: Ensure the specified input format is CTF
Jérémie Galarneau [Fri, 1 Mar 2013 02:27:45 +0000 (21:27 -0500)] 
Fix: Ensure the specified input format is CTF

Add a check to make sure the input trace format argument passed to the
babeltrace converter is "ctf" as it is currently the only one supported.

Add a note to this effect in the man page.

Fixes #462

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agoFix: Undefined behavior of double free on strlist in get_names_args
Christian Babeux [Fri, 1 Mar 2013 02:26:32 +0000 (21:26 -0500)] 
Fix: Undefined behavior of double free on strlist in get_names_args

Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agoFix: ctf-text: don't close stdout
Mathieu Desnoyers [Fri, 22 Feb 2013 20:26:47 +0000 (15:26 -0500)] 
Fix: ctf-text: don't close stdout

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agoFix: warning message for unexpected trace byte order
Mathieu Desnoyers [Fri, 22 Feb 2013 16:09:43 +0000 (11:09 -0500)] 
Fix: warning message for unexpected trace byte order

Fixes #443

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agoNamespace the struct declaration
Julien Desfossez [Fri, 15 Feb 2013 19:26:54 +0000 (14:26 -0500)] 
Namespace the struct declaration

This struct is exposed in the public API so we need to namespace it.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agoNamespace the struct definition
Julien Desfossez [Fri, 15 Feb 2013 19:22:09 +0000 (14:22 -0500)] 
Namespace the struct definition

This struct is exposed in the public API, so we need to namespace it.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agoNamespace the struct format
Julien Desfossez [Fri, 15 Feb 2013 19:21:31 +0000 (14:21 -0500)] 
Namespace the struct format

This struct is exposed in the public API, we need to namespace it.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agoNamespace the struct mmap_stream
Julien Desfossez [Fri, 15 Feb 2013 19:20:54 +0000 (14:20 -0500)] 
Namespace the struct mmap_stream

This struct is exposed in the public API so we need to namespace it.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agoNamespace the struct trace_descriptor
Julien Desfossez [Fri, 15 Feb 2013 19:20:16 +0000 (14:20 -0500)] 
Namespace the struct trace_descriptor

This struct is exposed in the public API so we need to namespace it.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agoNamespace struct stream_pos
Julien Desfossez [Fri, 15 Feb 2013 19:18:47 +0000 (14:18 -0500)] 
Namespace struct stream_pos

This struct is exposed by the API, so we need to namespace it.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agoNamespace compliance for dependencies function
Julien Desfossez [Fri, 15 Feb 2013 19:17:57 +0000 (14:17 -0500)] 
Namespace compliance for dependencies function

Use the bt_ prefix instead of babeltrace_

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agoCleanup error messages
Mathieu Desnoyers [Thu, 14 Feb 2013 22:25:21 +0000 (17:25 -0500)] 
Cleanup error messages

Ensure we print a more meaningful error message when empty metadata
string is encountered.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agoFix: babeltrace: make '-w' actually work
Sebastian Andrzej Siewior [Thu, 14 Feb 2013 15:38:16 +0000 (10:38 -0500)] 
Fix: babeltrace: make '-w' actually work

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agoConvert the unit tests to the TAP format
Jérémie Galarneau [Wed, 13 Feb 2013 19:41:28 +0000 (14:41 -0500)] 
Convert the unit tests to the TAP format

[ Mathieu Desnoyers: minor style edits. ]

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agoSpelling cleanups within comments
Etienne Bergeron [Wed, 13 Feb 2013 02:32:13 +0000 (21:32 -0500)] 
Spelling cleanups within comments

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agoMove the bitfield test to tests/lib/
Jérémie Galarneau [Thu, 7 Feb 2013 22:30:52 +0000 (17:30 -0500)] 
Move the bitfield test to tests/lib/

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agoFix: Added a null pointer check to bt_ctf_field_name
Jérémie Galarneau [Mon, 28 Jan 2013 16:06:59 +0000 (11:06 -0500)] 
Fix: Added a null pointer check to bt_ctf_field_name

This function is called indirectly when calling __repr__ (print) in the
python bindings on the definition object returned by the
get_top_level_scope method thus resulting in a segmentation fault when
the name attribute is not set.

Fixes #373

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agoAdd babeltrace.pc to gitignore
Mathieu Desnoyers [Fri, 25 Jan 2013 17:00:08 +0000 (12:00 -0500)] 
Add babeltrace.pc to gitignore

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agonamespacing: place flex/bison symbols under bt_yy namespace
Mathieu Desnoyers [Thu, 24 Jan 2013 23:25:04 +0000 (18:25 -0500)] 
namespacing: place flex/bison symbols under bt_yy namespace

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agonamespace the lookup_integer function
Julien Desfossez [Thu, 24 Jan 2013 22:25:34 +0000 (17:25 -0500)] 
namespace the lookup_integer function

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agonamespace the definition functions
Julien Desfossez [Thu, 24 Jan 2013 22:25:16 +0000 (17:25 -0500)] 
namespace the definition functions

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agonamespace the variant functions
Julien Desfossez [Thu, 24 Jan 2013 22:25:00 +0000 (17:25 -0500)] 
namespace the variant functions

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agonamespace the declaration functions
Julien Desfossez [Thu, 24 Jan 2013 22:24:45 +0000 (17:24 -0500)] 
namespace the declaration functions

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agonamespace the collection functions
Julien Desfossez [Thu, 24 Jan 2013 22:24:24 +0000 (17:24 -0500)] 
namespace the collection functions

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agonamespace the heap functions
Julien Desfossez [Thu, 24 Jan 2013 22:24:09 +0000 (17:24 -0500)] 
namespace the heap functions

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agonamespace the struct functions
Julien Desfossez [Thu, 24 Jan 2013 22:23:54 +0000 (17:23 -0500)] 
namespace the struct functions

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agonamespace the string functions
Julien Desfossez [Thu, 24 Jan 2013 22:23:39 +0000 (17:23 -0500)] 
namespace the string functions

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agonamespace the sequence functions
Julien Desfossez [Thu, 24 Jan 2013 22:23:19 +0000 (17:23 -0500)] 
namespace the sequence functions

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agonamespace the int functions
Julien Desfossez [Thu, 24 Jan 2013 22:22:59 +0000 (17:22 -0500)] 
namespace the int functions

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agonamespace the enum functions
Julien Desfossez [Thu, 24 Jan 2013 22:21:48 +0000 (17:21 -0500)] 
namespace the enum functions

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agonamespace definition_ref and definition_unref
Julien Desfossez [Thu, 24 Jan 2013 22:22:14 +0000 (17:22 -0500)] 
namespace definition_ref and definition_unref

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agonamespace declaration_ref and declaration_unref
Julien Desfossez [Thu, 24 Jan 2013 22:21:27 +0000 (17:21 -0500)] 
namespace declaration_ref and declaration_unref

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agonamespace the array functions
Julien Desfossez [Thu, 24 Jan 2013 22:20:54 +0000 (17:20 -0500)] 
namespace the array functions

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agonamespace the scope_path functions
Julien Desfossez [Thu, 24 Jan 2013 22:20:38 +0000 (17:20 -0500)] 
namespace the scope_path functions

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agoHide internal functions of libbabeltrace-ctf
Julien Desfossez [Thu, 24 Jan 2013 22:20:11 +0000 (17:20 -0500)] 
Hide internal functions of libbabeltrace-ctf

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agoHide internal functions of ctf-text
Julien Desfossez [Thu, 24 Jan 2013 22:19:51 +0000 (17:19 -0500)] 
Hide internal functions of ctf-text

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agoBT_HIDDEN macro
Julien Desfossez [Thu, 24 Jan 2013 22:19:22 +0000 (17:19 -0500)] 
BT_HIDDEN macro

This macro will be used across the codebase to set the visibility of a
function to hidden.
Updated also the functions that were setting the attribute manually.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agoNamespace the lookup_enum function
Julien Desfossez [Thu, 24 Jan 2013 17:32:26 +0000 (12:32 -0500)] 
Namespace the lookup_enum function

This patch namespaces the lookup_enum function because it causes problem
with the integration in gdb even though it is not exported.
This patch is a first step in the namespacing of the whole internal and
external code base.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agoVersion 1.0.3 v1.0.3
Mathieu Desnoyers [Thu, 24 Jan 2013 16:55:35 +0000 (11:55 -0500)] 
Version 1.0.3

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agoFix: Double free when calling bt_context_remove_trace()
Jérémie Galarneau [Mon, 21 Jan 2013 21:22:01 +0000 (16:22 -0500)] 
Fix: Double free when calling bt_context_remove_trace()

ctf_close_trace was being called twice when calling
bt_context_remove_trace thus causing free() to be called on an invalid
pointer.

Calling bt_context_remove_trace() would call ctf_close_trace() once via
the close_handle callback registered on the ctf format struct and a
second call would take place from bt_trace_handle_destroy() which is
registered as the value_destroy_func on the trace_handles hash table of
the current context.

bt_trace_handle_destroy() now only deallocates the trace handle and does
not perform the trace closing. This makes the
bt_trace_handle_create/destroy and bt_context_add/remove_trace parts of
the public API symmetric.

The crash is reproducible by invoking the tests-python.py script.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agoAdd missing runall.sh to dist packaging
Yannick Brosseau [Fri, 18 Jan 2013 18:15:11 +0000 (13:15 -0500)] 
Add missing runall.sh to dist packaging

Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agoFix: alignment of compound types containing array field
Mathieu Desnoyers [Thu, 17 Jan 2013 01:08:10 +0000 (20:08 -0500)] 
Fix: alignment of compound types containing array field

The "alignment" field of the array declaration is used by compound types
containing an array field to calculate the alignment needed for the
compound types.

Reported-by: Simon Marchi <simon.marchi@polymtl.ca>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agoVersion 1.0.2 v1.0.2
Mathieu Desnoyers [Fri, 11 Jan 2013 14:46:40 +0000 (09:46 -0500)] 
Version 1.0.2

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agoFix: add tests/lib missing files to Makefile.am
Mathieu Desnoyers [Fri, 11 Jan 2013 14:42:12 +0000 (09:42 -0500)] 
Fix: add tests/lib missing files to Makefile.am

Fix make dist.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agoVersion 1.0.1 v1.0.1
Mathieu Desnoyers [Fri, 11 Jan 2013 14:36:12 +0000 (09:36 -0500)] 
Version 1.0.1

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agoProvides a basic pkg-config file for libbabeltrace
Yannick Brosseau [Fri, 14 Dec 2012 12:35:09 +0000 (07:35 -0500)] 
Provides a basic pkg-config file for libbabeltrace

This pkg-config file specify the usage of libbabeltrace and
libbabeltrace-ctf since ctf is the only format currently supported and
tested.

Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agoFix erroneous warning/error messages
Simon Marchi [Thu, 6 Dec 2012 16:21:10 +0000 (11:21 -0500)] 
Fix erroneous warning/error messages

This led to user confusion.

Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agoFix comment in context.h
Mathieu Desnoyers [Wed, 5 Dec 2012 20:46:02 +0000 (15:46 -0500)] 
Fix comment in context.h

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agoCleanup: Remove whitespace at EOL from mit-license.txt
Mathieu Desnoyers [Wed, 5 Dec 2012 13:06:44 +0000 (08:06 -0500)] 
Cleanup: Remove whitespace at EOL from mit-license.txt

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
9 years agoAdd missing permission notice in each source file
Mathieu Desnoyers [Wed, 5 Dec 2012 12:50:56 +0000 (07:50 -0500)] 
Add missing permission notice in each source file

The permission notice was already present in the project mit-license.txt
file (refered to by the README file), but we should add it to each file.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoAdding a test which do a sequence of seek BEGIN, LAST, BEGIN, LAST
Yannick Brosseau [Sat, 17 Nov 2012 16:22:01 +0000 (11:22 -0500)] 
Adding a test which do a sequence of seek BEGIN, LAST, BEGIN, LAST

Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoRun seek tests on a second trace file
Yannick Brosseau [Sat, 17 Nov 2012 16:21:11 +0000 (11:21 -0500)] 
Run seek tests on a second trace file

Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoAdd #define _GNU_SOURCE to remove warning about asprintf
Yannick Brosseau [Fri, 16 Nov 2012 22:23:33 +0000 (17:23 -0500)] 
Add #define _GNU_SOURCE to remove warning about asprintf

Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoInclude a test for SEEK_BEGIN and SEEK_LAST
Yannick Brosseau [Fri, 16 Nov 2012 15:27:21 +0000 (10:27 -0500)] 
Include a test for SEEK_BEGIN and SEEK_LAST

[ Edit by Mathieu Desnoyers: style fixes, add NR_TESTS define. ]

Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoFix: Report success even if we find at least one valid stream in find_max_timestamp_c...
Yannick Brosseau [Thu, 15 Nov 2012 22:06:33 +0000 (17:06 -0500)] 
Fix: Report success even if we find at least one valid stream in find_max_timestamp_ctf_stream_class

Fix the case were the last stream is completely empty and return EOF.
This return value was returned even if other streams were valid

Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoFix SEEK_BEGIN for streams that do not contain any event
Mathieu Desnoyers [Fri, 9 Nov 2012 18:02:59 +0000 (13:02 -0500)] 
Fix SEEK_BEGIN for streams that do not contain any event

Reported-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoVersion 1.0.0 v1.0.0
Mathieu Desnoyers [Sat, 27 Oct 2012 15:23:38 +0000 (11:23 -0400)] 
Version 1.0.0

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agotests: add test traces to distribution tarball
Mathieu Desnoyers [Sat, 27 Oct 2012 15:22:22 +0000 (11:22 -0400)] 
tests: add test traces to distribution tarball

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoDocument bash requirement for make check in README
Mathieu Desnoyers [Sat, 27 Oct 2012 15:16:38 +0000 (11:16 -0400)] 
Document bash requirement for make check in README

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoAdd tests to make check
Mathieu Desnoyers [Sat, 27 Oct 2012 15:09:36 +0000 (11:09 -0400)] 
Add tests to make check

Fixes #361

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoFix: add missing header size validation
Mathieu Desnoyers [Sat, 27 Oct 2012 15:08:07 +0000 (11:08 -0400)] 
Fix: add missing header size validation

Was causing infinite loop for
tests/ctf-traces/fail/lttng-modules-2.0-pre1 failure test.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agocallbacks.c: handle extract_ctf_stream_event return value
Mathieu Desnoyers [Tue, 23 Oct 2012 19:46:31 +0000 (15:46 -0400)] 
callbacks.c: handle extract_ctf_stream_event return value

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoCleanup: fix cppcheck warning
Mathieu Desnoyers [Mon, 22 Oct 2012 22:32:49 +0000 (18:32 -0400)] 
Cleanup: fix cppcheck warning

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoCleanup: fix cppcheck warnings
Mathieu Desnoyers [Mon, 22 Oct 2012 22:31:11 +0000 (18:31 -0400)] 
Cleanup: fix cppcheck warnings

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agofix double-free on error path
Mathieu Desnoyers [Mon, 22 Oct 2012 22:23:09 +0000 (18:23 -0400)] 
fix double-free on error path

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoVersion 1.0.0-rc6 v1.0.0-rc6
Mathieu Desnoyers [Thu, 18 Oct 2012 20:45:24 +0000 (16:45 -0400)] 
Version 1.0.0-rc6

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoAdd valgrind suppression file for libpopt
Mathieu Desnoyers [Thu, 18 Oct 2012 20:41:20 +0000 (16:41 -0400)] 
Add valgrind suppression file for libpopt

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoFix: unplug memory leak that causes popt-0.13 to segfault
Mathieu Desnoyers [Thu, 18 Oct 2012 12:54:10 +0000 (08:54 -0400)] 
Fix: unplug memory leak that causes popt-0.13 to segfault

popt-0.16 poptGetArg() causes a memory leak, but freeing that memory
goes against popt(3) documented use, and against the 0.13 behavior,
which triggers a segfault on free(). So leave this small,
one-time-per-execution, memory leak in place.

Fixes #380

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoFix: test all close/fclose ret val, fix double close
Mathieu Desnoyers [Wed, 17 Oct 2012 18:23:02 +0000 (14:23 -0400)] 
Fix: test all close/fclose ret val, fix double close

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoCleanup: add missing newline
Mathieu Desnoyers [Wed, 17 Oct 2012 15:54:07 +0000 (11:54 -0400)] 
Cleanup: add missing newline

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoFix: fd leak on trace close
Mathieu Desnoyers [Wed, 17 Oct 2012 15:53:52 +0000 (11:53 -0400)] 
Fix: fd leak on trace close

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoFix memory leaks induced by lack of libpopt documentation
Mathieu Desnoyers [Tue, 16 Oct 2012 22:58:11 +0000 (18:58 -0400)] 
Fix memory leaks induced by lack of libpopt documentation

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agobabeltrace: fix poptGetOptArg memleak
Mathieu Desnoyers [Tue, 16 Oct 2012 22:37:00 +0000 (18:37 -0400)] 
babeltrace: fix poptGetOptArg memleak

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoplugins: implement plugin unregister
Mathieu Desnoyers [Tue, 16 Oct 2012 22:04:39 +0000 (18:04 -0400)] 
plugins: implement plugin unregister

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoDoc: valgrind with babeltrace (glib workaround)
Julien Desfossez [Tue, 16 Oct 2012 18:47:09 +0000 (14:47 -0400)] 
Doc: valgrind with babeltrace (glib workaround)

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agocallsites: fix memory leak
Mathieu Desnoyers [Tue, 16 Oct 2012 18:41:41 +0000 (14:41 -0400)] 
callsites: fix memory leak

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoFix: free all the metadata-related memory
Julien Desfossez [Tue, 16 Oct 2012 18:25:33 +0000 (14:25 -0400)] 
Fix: free all the metadata-related memory

When opening a trace, the parser allocates various data structures to
represent internally the metadata.
This patch frees all this memory when a trace is closed.

When babeltrace was originally developed, it was meant to be mainly a
trace converter, so relying on the operating system to free memory was
"acceptable", although a bad practice. Now that libbabeltrace allows
reading the CTF format from an external application, it becomes clear
that fixing those memory leaks is required.

As of this commit, valgrind invoked in the following way on babeltrace
does not report any memory leak:
G_SLICE=always-malloc G_DEBUG=gc-friendly valgrind --leak-check=full

Let's keep it that way :-) !

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoFix : Free the iterator callback arrays
Julien Desfossez [Tue, 16 Oct 2012 18:24:15 +0000 (14:24 -0400)] 
Fix : Free the iterator callback arrays

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoFix : cleanup teardown of context
Julien Desfossez [Tue, 16 Oct 2012 18:23:12 +0000 (14:23 -0400)] 
Fix : cleanup teardown of context

Fix the error path when a trace is opened but errors occur when we index
it, and close all traces when the context is destroyed.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoFix : protect static float and double declarations
Julien Desfossez [Tue, 16 Oct 2012 18:20:58 +0000 (14:20 -0400)] 
Fix : protect static float and double declarations

Add a mutex in the constructor of float.c to protect the static
temporary float and double declared in case we add multi-threading
support some day.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agocallsite: support instruction pointer field
Mathieu Desnoyers [Tue, 16 Oct 2012 02:04:42 +0000 (22:04 -0400)] 
callsite: support instruction pointer field

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoDocument that list.h is LGPLv2.1, but entirely trivial
Mathieu Desnoyers [Tue, 2 Oct 2012 22:06:35 +0000 (18:06 -0400)] 
Document that list.h is LGPLv2.1, but entirely trivial

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoFix: callsite support: list multiple callsites
Mathieu Desnoyers [Tue, 2 Oct 2012 21:33:11 +0000 (17:33 -0400)] 
Fix: callsite support: list multiple callsites

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoAdd callsite support
Mathieu Desnoyers [Tue, 2 Oct 2012 18:47:18 +0000 (14:47 -0400)] 
Add callsite support

Callsite support has been added to the spec.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoFix: Allow 64-bit packet offset
Mathieu Desnoyers [Fri, 28 Sep 2012 00:56:53 +0000 (20:56 -0400)] 
Fix: Allow 64-bit packet offset

Offset within a packet is calculated in bits. Therefore, if, for an
unforeseen reason, a 32-bit system would happen to build babeltrace
without large file support, the maximum packet size would have been
limited to 256MB (4GB / 8 bits per byte), because we were using size_t.

Use 64-bit type to hold the offset within a packet from now on.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoFix: emf uri: surround by " "
Mathieu Desnoyers [Thu, 20 Sep 2012 16:50:26 +0000 (12:50 -0400)] 
Fix: emf uri: surround by " "

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoHandle model.emf.uri event info
Mathieu Desnoyers [Thu, 20 Sep 2012 16:37:09 +0000 (12:37 -0400)] 
Handle model.emf.uri event info

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoFix: Documentation cleanup
Julien Desfossez [Thu, 13 Sep 2012 22:47:34 +0000 (18:47 -0400)] 
Fix: Documentation cleanup

Add high-level information about declarations, definitions and scopes in
the API documentation.
Add some missing API function documentation in the API doc.
Clarify the usage of the declaration listing functions.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoFix: misplaced C++ ifdef
Julien Desfossez [Thu, 13 Sep 2012 20:27:43 +0000 (16:27 -0400)] 
Fix: misplaced C++ ifdef

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoFix babeltrace-log get big line when the input file last line don't have enter
Hui Zhu [Tue, 11 Sep 2012 13:28:59 +0000 (09:28 -0400)] 
Fix babeltrace-log get big line when the input file last line don't have enter

I got:
[Error] Line too large for packet size (32kB) (discarded)
When I input a file to babeltrace-log.
That is because the last line of the input file doesn't have enter and
"babeltrace-log" have bug with the line that doesn't have enter.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoAPI Fix: bt_ctf_iter_read_event_flags
Julien Desfossez [Tue, 11 Sep 2012 02:04:09 +0000 (22:04 -0400)] 
API Fix: bt_ctf_iter_read_event_flags

The new bt_ctf_iter_read_event_flags function behaves like
bt_ctf_iter_read_event but takes a flag pointer.
This flag is used by the trace reading code to inform the user if some
events were discarded by the tracer in the current packet.

The new bt_ctf_get_lost_events_count function allows the user to get the
the number of events discarded immediately prior to the last event read.

[ Edit by Mathieu Desnoyers: use enum instead of define for
  BT_ITER_FLAG_LOST_EVENTS. ]

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoFix: get encoding for char arrays and sequences
Julien Desfossez [Tue, 11 Sep 2012 02:01:58 +0000 (22:01 -0400)] 
Fix: get encoding for char arrays and sequences

The bt_ctf_get_encoding works for strings and integer, but not for char
arrays or sequences. For these compound types, we need to return the
encoding of the integer contained inside. This patch adds the support of
char arrays and sequences.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoFix: access to declaration from declaration_field
Julien Desfossez [Tue, 11 Sep 2012 02:01:05 +0000 (22:01 -0400)] 
Fix: access to declaration from declaration_field

Rename the bt_ctf_get_decl_fields into bt_ctf_get_decl_from_def and
introduce the new bt_ctf_get_decl_from_field_decl to allow the user to
access the declaration from a field_declaration.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoFix: get_declaration_* should not cast to field
Mathieu Desnoyers [Sat, 8 Sep 2012 23:37:46 +0000 (19:37 -0400)] 
Fix: get_declaration_* should not cast to field

Also add const typing.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoFix babeltrace-log uninitialized memory (v2)
Hui Zhu [Fri, 7 Sep 2012 13:16:55 +0000 (09:16 -0400)] 
Fix babeltrace-log uninitialized memory (v2)

Got a crash with babeltrace-log.

../../../babeltrace/include/babeltrace/mmap-align.h:78 index=0, whence=0)
  at ../../../babeltrace/formats/ctf/ctf.c:623
  at ../../../babeltrace/formats/ctf/ctf.c:576 _IO_2_1_stdin_
  at ../../babeltrace/converter/babeltrace-log.c:233
../../babeltrace/converter/babeltrace-log.c:342

This issue because pos is used before it init.  This patch init it in
function ctf_init_pos.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoRevert "Fix babeltrace-log uninitialized memory"
Mathieu Desnoyers [Fri, 7 Sep 2012 13:16:19 +0000 (09:16 -0400)] 
Revert "Fix babeltrace-log uninitialized memory"

This reverts commit 36741bea2b53007c29ac0391ee9086722e00653a.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoFix babeltrace-log uninitialized memory
Hui Zhu [Fri, 7 Sep 2012 12:36:28 +0000 (08:36 -0400)] 
Fix babeltrace-log uninitialized memory

Got a crash with babeltrace-log.

../../../babeltrace/include/babeltrace/mmap-align.h:78
index=0, whence=0)
    at ../../../babeltrace/formats/ctf/ctf.c:623
    at ../../../babeltrace/formats/ctf/ctf.c:576
<_IO_2_1_stdin_>)
    at ../../babeltrace/converter/babeltrace-log.c:233
../../babeltrace/converter/babeltrace-log.c:342

This issue because pos is used before it init.  This patch init it in
function ctf_init_pos.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoFix: access field properties by declaration
Julien Desfossez [Thu, 6 Sep 2012 21:42:26 +0000 (17:42 -0400)] 
Fix: access field properties by declaration

The functions that give access to the properties of the fields (int
signedness, base, char len, etc), were only working with definition
struct which prevented their use before actually reading the events.

This patch changes the prototypes of these functions to use
declarations instead of definitions and provides a converter
function to access the declaration from a definition.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoFix: check return value of get_char_array
Julien Desfossez [Tue, 28 Aug 2012 04:01:39 +0000 (00:01 -0400)] 
Fix: check return value of get_char_array

Arrays that are not char arrays will cause a segfault if we don't check
the return value of get_char_array before accessing the str pointer.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoFix: C++ support to API header files
Julien Desfossez [Mon, 27 Aug 2012 17:27:32 +0000 (13:27 -0400)] 
Fix: C++ support to API header files

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
This page took 0.040278 seconds and 4 git commands to generate.