Implement likely/unlikely ifdefs

- don't redefine likely/unlikely on compilers already defining them,
- don't use builtins on compilers not supporting them.

Signed-off-by: Etienne Bergeron <etienneb@google.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix unary constant use after error

Signed-off-by: Etienne Bergeron <etienneb@google.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Use new print macros in ctf-parser.y

Signed-off-by: Etienne Bergeron <etienneb@google.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Print error on invalid token

Includes an optimisation for ignored token parsing.

Signed-off-by: Etienne Bergeron <etienneb@google.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Implement macros for error printout

Signed-off-by: Etienne Bergeron <etienneb@google.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add line number to parser nodes

Signed-off-by: Etienne Bergeron <etienneb@google.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: handle errors gracefully

- Return errors in io struct generator rather than using assertions,
- check for NULL concatenate string return values,
- fix memleak on ctf_trace_declaration_visit error path.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: memleak on error path

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add missing NULL pointer check

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Show token in CTF parser error

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Remove unused lineno from struct ctf_scanner

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Show line numbers in CTF parser errors

Suggested-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Ignore Windows-style EOL character in metadata

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Replace AM_PROG_MKDIR obsolete macro with AC_PROG_MKDIR_P

The bootstrap script is complaining with a deprecation warning [1] for
the AM_PROG_MKDIR_P Automake macro.

Relevant bootstrap output:

configure.ac:13: warning: The 'AM_PROG_MKDIR_P' macro is deprecated,
                 and will soon be removed.
configure.ac:13: You should use the Autoconf-provided 'AC_PROG_MKDIR_P'
                 macro instead,
configure.ac:13: and use '$(MKDIR_P)' instead of '$(mkdir_p)'in your
                 Makefile.am files.

Fix this by updating configure.ac with the proposed AC_PROG_MKDIR_P macro.

[1] - https://www.gnu.org/software/automake/manual/html_node/Obsolete-Macros.html

Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Version 1.1.0

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Reinsert "at end of stream" message for discarded events

Ref #469

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Improvement: Message from babeltrace concerning discarded events needs improvement

New output example:

[warning] Tracer discarded 18508 events between [13:07:22.210641404] and [13:07:22.210642166] in trace UUID 857bd6395891954ab9d3defb2aeb98f7, at path: "/home/compudj/lttng-traces/auto-20130323-130705/kernel", within stream id 0, at relative path: "channel0_1". You should consider recording a new trace with larger buffers or with fewer events enabled.

Fixes #469

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Cleanup: typo fix

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Cleanup: add end of line at end of verbose message

Fixes #470

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: misleading message from babeltrace --verbose

Fixes #468

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: babeltrace --fields all  overrides --no-delta

Fixes #463

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add verbosity to stream id error message

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: Ensure the specified input format is CTF

Add a check to make sure the input trace format argument passed to the
babeltrace converter is "ctf" as it is currently the only one supported.

Add a note to this effect in the man page.

Fixes #462

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: Undefined behavior of double free on strlist in get_names_args

Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: ctf-text: don't close stdout

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: warning message for unexpected trace byte order

Fixes #443

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Namespace the struct declaration

This struct is exposed in the public API so we need to namespace it.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Namespace the struct definition

This struct is exposed in the public API, so we need to namespace it.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Namespace the struct format

This struct is exposed in the public API, we need to namespace it.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Namespace the struct mmap_stream

This struct is exposed in the public API so we need to namespace it.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Namespace the struct trace_descriptor

This struct is exposed in the public API so we need to namespace it.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Namespace struct stream_pos

This struct is exposed by the API, so we need to namespace it.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Namespace compliance for dependencies function

Use the bt_ prefix instead of babeltrace_

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Cleanup error messages

Ensure we print a more meaningful error message when empty metadata
string is encountered.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: babeltrace: make '-w' actually work

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Convert the unit tests to the TAP format

[ Mathieu Desnoyers: minor style edits. ]

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Spelling cleanups within comments

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Move the bitfield test to tests/lib/

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: Added a null pointer check to bt_ctf_field_name

This function is called indirectly when calling __repr__ (print) in the
python bindings on the definition object returned by the
get_top_level_scope method thus resulting in a segmentation fault when
the name attribute is not set.

Fixes #373

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add babeltrace.pc to gitignore

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

namespacing: place flex/bison symbols under bt_yy namespace

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

namespace the lookup_integer function

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

namespace the definition functions

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

namespace the variant functions

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

namespace the declaration functions

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

namespace the collection functions

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

namespace the heap functions

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

namespace the struct functions

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

namespace the string functions

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

namespace the sequence functions

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

namespace the int functions

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

namespace the enum functions

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

namespace definition_ref and definition_unref

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

namespace declaration_ref and declaration_unref

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

namespace the array functions

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

namespace the scope_path functions

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Hide internal functions of libbabeltrace-ctf

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Hide internal functions of ctf-text

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

BT_HIDDEN macro

This macro will be used across the codebase to set the visibility of a
function to hidden.
Updated also the functions that were setting the attribute manually.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Namespace the lookup_enum function

This patch namespaces the lookup_enum function because it causes problem
with the integration in gdb even though it is not exported.
This patch is a first step in the namespacing of the whole internal and
external code base.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Version 1.0.3

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: Double free when calling bt_context_remove_trace()

ctf_close_trace was being called twice when calling
bt_context_remove_trace thus causing free() to be called on an invalid
pointer.

Calling bt_context_remove_trace() would call ctf_close_trace() once via
the close_handle callback registered on the ctf format struct and a
second call would take place from bt_trace_handle_destroy() which is
registered as the value_destroy_func on the trace_handles hash table of
the current context.

bt_trace_handle_destroy() now only deallocates the trace handle and does
not perform the trace closing. This makes the
bt_trace_handle_create/destroy and bt_context_add/remove_trace parts of
the public API symmetric.

The crash is reproducible by invoking the tests-python.py script.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add missing runall.sh to dist packaging

Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: alignment of compound types containing array field

The "alignment" field of the array declaration is used by compound types
containing an array field to calculate the alignment needed for the
compound types.

Reported-by: Simon Marchi <simon.marchi@polymtl.ca>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Version 1.0.2

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: add tests/lib missing files to Makefile.am

Fix make dist.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Version 1.0.1

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Provides a basic pkg-config file for libbabeltrace

This pkg-config file specify the usage of libbabeltrace and
libbabeltrace-ctf since ctf is the only format currently supported and
tested.

Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix erroneous warning/error messages

This led to user confusion.

Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix comment in context.h

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Cleanup: Remove whitespace at EOL from mit-license.txt

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add missing permission notice in each source file

The permission notice was already present in the project mit-license.txt
file (refered to by the README file), but we should add it to each file.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Adding a test which do a sequence of seek BEGIN, LAST, BEGIN, LAST

Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Run seek tests on a second trace file

Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add #define _GNU_SOURCE to remove warning about asprintf

Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Include a test for SEEK_BEGIN and SEEK_LAST

[ Edit by Mathieu Desnoyers: style fixes, add NR_TESTS define. ]

Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: Report success even if we find at least one valid stream in find_max_timestamp_ctf_stream_class

Fix the case were the last stream is completely empty and return EOF.
This return value was returned even if other streams were valid

Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix SEEK_BEGIN for streams that do not contain any event

Reported-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Version 1.0.0

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

tests: add test traces to distribution tarball

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Document bash requirement for make check in README

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add tests to make check

Fixes #361

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: add missing header size validation

Was causing infinite loop for
tests/ctf-traces/fail/lttng-modules-2.0-pre1 failure test.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

callbacks.c: handle extract_ctf_stream_event return value

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Cleanup: fix cppcheck warning

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Cleanup: fix cppcheck warnings

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

fix double-free on error path

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Version 1.0.0-rc6

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add valgrind suppression file for libpopt

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: unplug memory leak that causes popt-0.13 to segfault

popt-0.16 poptGetArg() causes a memory leak, but freeing that memory
goes against popt(3) documented use, and against the 0.13 behavior,
which triggers a segfault on free(). So leave this small,
one-time-per-execution, memory leak in place.

Fixes #380

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: test all close/fclose ret val, fix double close

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Cleanup: add missing newline

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: fd leak on trace close

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix memory leaks induced by lack of libpopt documentation

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

babeltrace: fix poptGetOptArg memleak

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

plugins: implement plugin unregister

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Doc: valgrind with babeltrace (glib workaround)

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

callsites: fix memory leak

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix: free all the metadata-related memory

When opening a trace, the parser allocates various data structures to
represent internally the metadata.
This patch frees all this memory when a trace is closed.

When babeltrace was originally developed, it was meant to be mainly a
trace converter, so relying on the operating system to free memory was
"acceptable", although a bad practice. Now that libbabeltrace allows
reading the CTF format from an external application, it becomes clear
that fixing those memory leaks is required.

As of this commit, valgrind invoked in the following way on babeltrace
does not report any memory leak:
G_SLICE=always-malloc G_DEBUG=gc-friendly valgrind --leak-check=full

Let's keep it that way :-) !

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix : Free the iterator callback arrays

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>