Install plugins in $(libdir)/babeltrace/plugins

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Plugins: rename reader -> fs, and symbols.c to plugin.c

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Plugins: remove unnecessary stuff in Makefile.am files

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Move plugin system sources to lib/plugin-system

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Strip babeltrace.c

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Add base plug-in skeletons

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

List detected component classes

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Fix header guard

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Component creation

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Introduce public component class interface

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Remove specialized reference counting functions

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Plugin symbol resolving fix

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Coding style fix

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Build fix

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

text plugin test

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Create sink plugins

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Discover plugins in converter.c

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Adapt plugin system to use unified reference counting

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Add ctf-text entry point initialization comment

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

ctf-text plugin stub

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Resolve plugin symbols

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Introduce bt_plugin and bt_component_class

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Load plugins and components

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Start of bt_component_factory implementation

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Docs: plugin-system.h documentation

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Move initialization of components to init functions

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Missing Makefiles

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Add iterator and source implementations

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Remove unneeded __cplusplus externs from source internal header

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Implementation of bt_component_sink_handle_notification

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Build fix and sink implementation

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Rename plugin.c to component.c in Makefile

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Rename plugin implementation to component

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Rename to separate the plug-in and component notions

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Rename plugin-internal.h to component-internal.h

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Missing notification parameter in bt_component_sink_handle_notification

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

More modifications

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Integrate modifications after plugin review

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Add options to ctf-text plugin

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Implement ctf text output plug-in stub

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Build system: build reader plug-in stub

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Add initial plug-in stubs

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

More build fixes

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

build fixes

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

remove extra line in reader

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Implement source plugin base

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Error stream is now an attribute of the base plugin class

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Implement plugin base class

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Start ctf reader implementation stub

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Add headers to build system

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Notification interfaces

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Add notification documentation

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

iterator documentation

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Add notification iterator documentation

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

source interface documentation

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

plugin-system.h documentation

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Add missing header plugin-system.h

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Minor fixes

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Add javadoc documentation of plugin-lib interface

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Javadoc fixes

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Comment plug-in error codes

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Document plug-in interface

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Plug-in system update

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Add discarded events notification type

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Plug-in API corrections

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Reader plugin skeleton

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Add plugin base implementation

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Add plugin interface to build system

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Initial plug-in interface draft

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Port: Add glib g_mkdtemp to mkdtemp wrapper

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Port: Use glib g_mkdir

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Cleanup: bt namespace for compat glib

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Cleanup: bt namespace for compat memstream.h

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Cleanup: bt namespace for compat timegm

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Cleanup: bt namespace for compat strerror_r

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Use glib portable macros to convert gpointer to int

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

ax_lib_elfutils -> bt_lib_elfutils

`ax` is a prefix for the GNU Autoconf Archive. `ax_lib_elfutils`
should be namespaced within the project here, with the `bt_` prefix.

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

m4/ax_lib_elfutils.m4: use m4_default() for optional args.

The current macro code does not work because, if you provide 4
arguments to the macro, then `true_action` is not defined (but
it should be: it's the third argument).

Use m4_default() here to expand to a default value if the
argument does not exist.

Also use [:] instead of [] (good practice, safer for shells).

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

m4/ax_lib_elfutils.m4: add cache variable

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Fix: text output missing separator when printing the domain

With the "-f all" option, we expect to see
<hostname>:<domain>:<loglevel>, but instead we see
<hostname><domain>:<loglevel>.

Judging from the pattern of the other printed fields, the check for
"dom_print" variable seems to be missing when printing the domain.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Fix: perform an explicit stdout flush in live even on empty packets

This ensures that babeltrace makes the content of live buffers
visible even if the data packets received are empty.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Fix: documentation: output plugin is called ctf-metadata

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Fix: Use autoconf provided grep in test_formats

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

babeltrace: add test for babeltrace --list

This test simply checks the converter's list of supported formats.

Signed-off-by: Nathan Lynch <nathan_lynch@mentor.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Add empty plug-in hooks to prevent their elimination by the linker

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Remove useless PACKAGE_LIBS substitution

PACKAGE_LIBS isn't referred to anywhere in the project so remove this
dead code from configure.ac.

Signed-off-by: Nathan Lynch <nathan_lynch@mentor.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Do not use g_quark_from_static_string in unloadable code

The GLib Quark documentation says that g_quark_from_static_string:

   "... can only be used if the string will continue to exist until the
    program terminates. It can be used with statically allocated
    strings in the main program, but not with statically allocated
    memory in dynamically loaded modules."

https://developer.gnome.org/glib/stable/glib-Quarks.html#g-quark-from-static-string

Convert call sites of g_quark_from_static_string to
g_quark_from_string in code that is potentially unloadable. Call
sites in the babeltrace main program remain unchanged.

Signed-off-by: Nathan Lynch <nathan_lynch@mentor.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

CTF writer: Add function to add an integer environment field value

From the Python API, it's only possible to set an environment field
value as a string (whatever you pass, it gets stringified). This patch
adds a function to the CTF writer to allow setting an integer (int64_t)
environment field, and then exposes it in the Python interface.

The Python method Writer.add_environment_field now uses the type of the
passed value to determine which underlying C function to call (string or
integer). Any other type is rejected. This causes a behavior change,
since passing an integer value to add_environment_field used to produce
a string version of the value, whereas it will now produce an integer
version. However, I think it will now behave more closely to the
expectation of a lambda user.

Example:

  w.add_environment_field("foo", 2)

Result before:

  env {
    foo = "2";
  };

Result after:

  env {
    foo = 2;
  };

Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

python: Add stream event context support

This patch adds the possibility to get/set the event context type of a
stream class and set the stream context value of an event from Python.

From my experience, the value setter (Event.stream_context.setter) is
not so useful, since it looks like the context is already instanciated
when you create the event.  So in order to set the values in it, you
only need to get the existing instance and set its fields.  There is no
need to to re-assign the stream context instance to the event.  I still
put it there for completeness.

I added an example of the usage to the existing CTF writer Python
example.

Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

debug info: Call register_event_debug_infos for all events

The register_event_debug_infos function is responsible for setting the
debug_info_src field of the struct definition_integer representing the
"ip" context field.  This pointer is used later to print the
source and binary location of the tracepoint.

Currently, it's not called for the events that have a special meaning
for the debug info analysis (statedump start, dlopen, bin_info, etc).
This means that for these events, the debug_info_src pointer keeps the
value of the previous event from that stream (since the ip field is in
stream event context, there is one instance per stream), which leads to
wrong information and/or crash.  A crash can happen when the debug info
structures are cleared because a statedump start is encountered.
debug_info_src becomes a stale pointer and babeltrace tries to print a
string in free memory.

The fix is to call register_event_debug_infos for all events, which will
always set debug_info_src properly.  The events used to do the debug
info analysis are still regular events and have their own location
information.

The trace in bug #1018 shows a crash caused by this issue.

Here's an example of wrong info from the same trace:

... lttng_ust_statedump:bin_info: { cpu_id = 1 }, { vpid = 28991, ip = 0x7FD26665657D, debug_info = { bin = "libX11.so.6.3.0+0x213fa" } }, ...
... lttng_ust_statedump:build_id: { cpu_id = 1 }, { vpid = 28991, ip = 0x7FD266656656, debug_info = { bin = "libX11.so.6.3.0+0x213fa" } }, ...

We can see that the ip values are different, but the debug info refers
to the same location, which is impossible.  Here's the result with this
patch applied.

... lttng_ust_statedump:bin_info: { cpu_id = 1 }, { vpid = 28991, ip = 0x7FD26665657D, debug_info = { bin = "liblttng-ust.so.0.0.0+0x3557d", func = "trace_bin_info_cb+0xfa" } }, ...
... lttng_ust_statedump:build_id: { cpu_id = 1 }, { vpid = 28991, ip = 0x7FD266656656, debug_info = { bin = "liblttng-ust.so.0.0.0+0x35656", func = "trace_build_id_cb+0xbc" } }, ...

which seems more reasonnable.

Fixed #1018

Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Typo: configure.ac implemenation -> implementation

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

configure: fix uuid support detection on static build

This change adds uuid detection using pkg-config helper before falling
back on the standard AC_CHECK_LIB detection for platforms missing
pkg-config.

AC_CHECK_LIB function achieves its test by trying to link against the
requested library, without taking care of its dependency
requirements/flags that may differ between different targets.
Therefore, in case of static build, it can fail on the uuid detection
like [1], because the uuid's dependency flags (regarding gettext) are
missing.

Instead, using pkg-config to do the check will take care of getting and
setting all required flags.

This issue [1] has been triggered on Buildroot farms.

[1] http://autobuild.buildroot.net/results/43b/43b98ddf9eb44152ed9ac4a98d887af14831d8da/build-end.log

Signed-off-by: Samuel Martin <s.martin49@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Fix: don't assert on lib unload failure

A library's load event might have been missed because of
discarded events. In this scenario, it is expected that its
mapping will not be found on unload.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Use lib unload events to prune library mappings

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Rename handle_dlopen_event to handle_lib_load_event

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Use lttng-ust's new load event to track library mappings

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Tests: no substitution needed for multi-trace intersection test

The use of AC_CONFIG_FILES on with src == dest causes the source
file to be deleted on make distclean.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Tests: dereference of NULL pointer on allocation failure

Reported by Coverity as:
CID 1354904 (#1 of 1): Dereference null return value (NULL_RETURNS)

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Tests: abort dwarf test on open() failure

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Fix: lttng-live does not set a trace descriptor

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>