From ef9559ae12282108e1af00e08809d8f04946ab77 Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Wed, 16 Oct 2019 15:27:11 -0400 Subject: [PATCH] Bump required glib version to 2.28 While investigating a hang in the lttng-live source component when running with glib 2.22.5, we have found that this version had a bug in g_ptr_array_remove_index_fast. When removing the last element of the array, the free func is not called. It was fixed in the following commit: https://github.com/GNOME/glib/commit/5fffa39b6ae8f8faf1036fbf07de02ffe84ef099 The first major release where this is fixed is 2.26. We went through the platforms we need to support, and the oldest glib version we need to support is 2.28.6, on Solaris 11. Therefore, fix the issue with lttng-live by bumping the required glib version to 2.28. Change-Id: Ib56ac221dfc5ecf45eb62b837fe0b6f54032cf31 Signed-off-by: Simon Marchi Reviewed-on: https://review.lttng.org/c/babeltrace/+/2210 Reviewed-by: Michael Jeanson Reviewed-by: Jonathan Rajotte Julien Tested-by: jenkins --- README.adoc | 4 ++-- configure.ac | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/README.adoc b/README.adoc index a2ac98dc..e1983b6d 100644 --- a/README.adoc +++ b/README.adoc @@ -77,7 +77,7 @@ Libraries:: * A C library (for example, https://www.gnu.org/software/libc/[GNU{nbsp}C Library], https://www.musl-libc.org/[musl libc]) - * https://developer.gnome.org/glib/[GLib]{nbsp}≥{nbsp}2.22 + * https://developer.gnome.org/glib/[GLib]{nbsp}≥{nbsp}2.28 (Debian/Ubuntu: `libglib2.0-dev`; Fedora: `glib2-devel`) _**If you need the `bt2` Python bindings**_:: @@ -250,7 +250,7 @@ Libraries:: * A C library (for example, https://www.gnu.org/software/libc/[GNU{nbsp}C Library], https://www.musl-libc.org/[musl libc]) - * https://developer.gnome.org/glib/[GLib]{nbsp}≥{nbsp}2.22 + * https://developer.gnome.org/glib/[GLib]{nbsp}≥{nbsp}2.28 (Debian/Ubuntu: `libglib2.0-0`; Fedora: `glib2`) _**If you need the `bt2` Python bindings**_:: diff --git a/configure.ac b/configure.ac index 0a630558..9e02f7e9 100644 --- a/configure.ac +++ b/configure.ac @@ -248,9 +248,9 @@ AM_CONDITIONAL([HAVE_FLEX], [test "x$have_flex" = "xyes"]) # Check what libraries are required on this platform to link sockets programs. AX_LIB_SOCKET_NSL -# Check for glib >= 2.22 with gmodule support -AM_PATH_GLIB_2_0([2.22.0], [], - AC_MSG_ERROR([glib >= 2.22 is required - download it from ftp://ftp.gtk.org/pub/gtk]), +# Check for glib >= 2.28 with gmodule support +AM_PATH_GLIB_2_0([2.28.0], [], + AC_MSG_ERROR([glib >= 2.28 is required - download it from ftp://ftp.gtk.org/pub/gtk]), [gmodule-no-export] ) -- 2.34.1