From 25afa9e5d7ccba1c3f9a0bdcb8d8992f4a832baa Mon Sep 17 00:00:00 2001 From: Mathieu Desnoyers Date: Fri, 1 Nov 2013 22:50:35 -0400 Subject: [PATCH] linter fix: comparison of fd >= 0 Signed-off-by: Mathieu Desnoyers --- tests/lib/test_ctf_writer.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/lib/test_ctf_writer.c b/tests/lib/test_ctf_writer.c index 8c168edb..d55c6297 100644 --- a/tests/lib/test_ctf_writer.c +++ b/tests/lib/test_ctf_writer.c @@ -100,7 +100,7 @@ void validate_metadata(char *parser_path, char *metadata_path) result: ok(ret == 0, "Metadata string is valid"); - if (ret && metadata_fd > 0 && parser_output_fd > 0) { + if (ret && metadata_fd >= 0 && parser_output_fd >= 0) { char *line; size_t len = METADATA_LINE_SIZE; FILE *metadata_fp = NULL, *parser_output_fp = NULL; @@ -150,12 +150,12 @@ close_fp: } } - if (parser_output_fd > 0) { + if (parser_output_fd >= 0) { if (close(parser_output_fd)) { diag("close error"); } } - if (metadata_fd > 0) { + if (metadata_fd >= 0) { if (close(metadata_fd)) { diag("close error"); } @@ -207,7 +207,7 @@ void validate_trace(char *parser_path, char *trace_path) result: ok(ret == 0, "Babeltrace could read the resulting trace"); - if (ret && babeltrace_output_fd > 0) { + if (ret && babeltrace_output_fd >= 0) { char *line; size_t len = METADATA_LINE_SIZE; FILE *babeltrace_output_fp = NULL; @@ -237,7 +237,7 @@ close_fp: } } - if (babeltrace_output_fd > 0) { + if (babeltrace_output_fd >= 0) { if (close(babeltrace_output_fd)) { diag("close error"); } -- 2.34.1