From 1726ac08cb44c6268d16c79c85e196112e3814b1 Mon Sep 17 00:00:00 2001 From: Jonathan Rajotte Date: Wed, 25 Sep 2019 17:13:39 -0400 Subject: [PATCH] Fix: tests: live: listen on python < 3.5 needs backlog parameter The backlog parameter is required on python version smaller then 3.5. On sles12sp2: Traceback (most recent call last): File "/home/jenkins/workspace/babeltrace_master_slesbuild/arch/sles12sp2/build/std/conf/prod/src/babeltrace/tests/data/plugins/src.ctf.lttng-live/lttng_live_server.py", line 1447, in args.port_filename, args.sessions, args.max_query_data_response_size File "/home/jenkins/workspace/babeltrace_master_slesbuild/arch/sles12sp2/build/std/conf/prod/src/babeltrace/tests/data/plugins/src.ctf.lttng-live/lttng_live_server.py", line 1232, in __init__ self._listen() File "/home/jenkins/workspace/babeltrace_master_slesbuild/arch/sles12sp2/build/std/conf/prod/src/babeltrace/tests/data/plugins/src.ctf.lttng-live/lttng_live_server.py", line 1323, in _listen self._sock.listen() TypeError: listen() takes exactly one argument (0 given) Signed-off-by: Jonathan Rajotte Change-Id: Ib923beb9eadf929714b3270aaa7a57ff6c52407e Reviewed-on: https://review.lttng.org/c/babeltrace/+/2096 Reviewed-by: Simon Marchi --- tests/data/plugins/src.ctf.lttng-live/lttng_live_server.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/data/plugins/src.ctf.lttng-live/lttng_live_server.py b/tests/data/plugins/src.ctf.lttng-live/lttng_live_server.py index 4c3c9ff4..416f9bca 100644 --- a/tests/data/plugins/src.ctf.lttng-live/lttng_live_server.py +++ b/tests/data/plugins/src.ctf.lttng-live/lttng_live_server.py @@ -1320,7 +1320,9 @@ class LttngLiveServer: def _listen(self): logging.info('Listening: port={}'.format(self._server_port)) - self._sock.listen() + # Backlog must be present for Python version < 3.5. + # 128 is an arbitrary number since we expect only 1 connection anyway. + self._sock.listen(128) self._conn, viewer_addr = self._sock.accept() logging.info( 'Accepted viewer: addr={}:{}'.format(viewer_addr[0], viewer_addr[1]) -- 2.34.1