From 2f137223b8772e0d64a022f923542c2f04197389 Mon Sep 17 00:00:00 2001 From: Jonathan Rajotte Date: Tue, 9 Jul 2019 12:53:44 -0400 Subject: [PATCH] tests: specify the timezone offset On mingw (Windows) EST alone resolve to UTC since windows does not recognize EST. We could also use "America/Toronto" but this would require more change to the test. Since this test is only there to test the TZ usage the actual value of TZ does not matter. UTC5 would have done the same job. Signed-off-by: Jonathan Rajotte Change-Id: I05270504c69a90d4e9893435d1c1b583579041ae Reviewed-on: https://review.lttng.org/c/babeltrace/+/1662 Reviewed-by: Michael Jeanson Reviewed-by: Philippe Proulx Tested-by: jenkins --- tests/cli/test_trimmer | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/tests/cli/test_trimmer b/tests/cli/test_trimmer index 9ef8980c..d6155785 100755 --- a/tests/cli/test_trimmer +++ b/tests/cli/test_trimmer @@ -116,7 +116,18 @@ expect_success 0 "--begin, out of range, GMT absolute timestamps" \ expect_success 0 "--begin, out of range, GMT absolute timestamps" \ --clock-gmt --end "2012-10-29 16:48:17.588680018" -export TZ=EST +# Note here that the POSIX notation is a bit weird. +# The libc documentation shed some light on this: +# The offset specifies the time value you must add to the local time to get a +# Coordinated Universal Time value. It has syntax like [+|-]hh[:mm[:ss]]. This +# is positive if the local time zone is west of the Prime Meridian and negative +# if it is east. The hour must be between 0 and 24, and the minute and seconds +# between 0 and 59. [1] +# +# This is why we use EST5 to simulate an effective UTC-5:00 time. +# +# [1] https://www.gnu.org/software/libc/manual/html_node/TZ-Variable.html +export TZ=EST5 expect_success 18 "--begin, EST relative timestamps" \ --begin "12:48:17.587029529" -- 2.34.1