From 2f69c7e71eff0b5b313a6737f8744605e7a6ce7f Mon Sep 17 00:00:00 2001 From: Michael Jeanson Date: Mon, 13 May 2019 11:16:35 -0400 Subject: [PATCH] Annotate implicit fall-through MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Signed-off-by: Michael Jeanson Change-Id: I21c5641869afca1fcac301f612d02d2cb10583db Reviewed-on: https://review.lttng.org/c/babeltrace/+/1293 Reviewed-by: Jérémie Galarneau --- common/common.c | 3 ++- .../common/metadata/ctf-meta-warn-meaningless-header-fields.c | 2 +- plugins/ctf/common/metadata/parser.y | 2 ++ 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/common/common.c b/common/common.c index de98e34c..68f537ba 100644 --- a/common/common.c +++ b/common/common.c @@ -822,7 +822,7 @@ void bt_common_normalize_star_glob_pattern(char *pattern) goto end; } - /* Fall through default case. */ + /* fall-through */ default: got_star = false; break; @@ -1042,6 +1042,7 @@ retry: * Fall through the default case which compares * the escaped character now. */ + /* fall-through */ default: if (at_end_of_pattern(p, pattern, pattern_len) || *c != *p) { diff --git a/plugins/ctf/common/metadata/ctf-meta-warn-meaningless-header-fields.c b/plugins/ctf/common/metadata/ctf-meta-warn-meaningless-header-fields.c index 943078ff..3abc7c9b 100644 --- a/plugins/ctf/common/metadata/ctf-meta-warn-meaningless-header-fields.c +++ b/plugins/ctf/common/metadata/ctf-meta-warn-meaningless-header-fields.c @@ -97,8 +97,8 @@ void warn_meaningless_fields(struct ctf_field_class *fc, const char *name, goto end; } - /* Fallthrough */ } + /* fall-through */ case CTF_FIELD_CLASS_TYPE_SEQUENCE: { struct ctf_field_class_array_base *array_fc = (void *) fc; diff --git a/plugins/ctf/common/metadata/parser.y b/plugins/ctf/common/metadata/parser.y index 2151f75d..504b2b28 100644 --- a/plugins/ctf/common/metadata/parser.y +++ b/plugins/ctf/common/metadata/parser.y @@ -883,11 +883,13 @@ static int set_parent_node(struct ctf_node *node, parent->u.field_class_alias.target = node; else return -EINVAL; + /* fall-through */ case NODE_TYPEALIAS_ALIAS: if (parent->type == NODE_TYPEALIAS) parent->u.field_class_alias.alias = node; else return -EINVAL; + /* fall-through */ case NODE_TYPEALIAS: return reparent_field_class_alias(node, parent); -- 2.34.1