From 36741bea2b53007c29ac0391ee9086722e00653a Mon Sep 17 00:00:00 2001 From: Hui Zhu Date: Fri, 7 Sep 2012 08:36:28 -0400 Subject: [PATCH] Fix babeltrace-log uninitialized memory Got a crash with babeltrace-log. ../../../babeltrace/include/babeltrace/mmap-align.h:78 index=0, whence=0) at ../../../babeltrace/formats/ctf/ctf.c:623 at ../../../babeltrace/formats/ctf/ctf.c:576 <_IO_2_1_stdin_>) at ../../babeltrace/converter/babeltrace-log.c:233 ../../babeltrace/converter/babeltrace-log.c:342 This issue because pos is used before it init. This patch init it in function ctf_init_pos. Signed-off-by: Mathieu Desnoyers --- formats/ctf/ctf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/formats/ctf/ctf.c b/formats/ctf/ctf.c index f43fe917..d4ff2a52 100644 --- a/formats/ctf/ctf.c +++ b/formats/ctf/ctf.c @@ -550,6 +550,7 @@ error: void ctf_init_pos(struct ctf_stream_pos *pos, int fd, int open_flags) { + memset(pos, 0, sizeof(*pos)); pos->fd = fd; if (fd >= 0) { pos->packet_cycles_index = g_array_new(FALSE, TRUE, -- 2.34.1