From 426de3806a9e0aae838d69bcc8e26762dd33c788 Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Fri, 26 Jan 2024 15:33:32 +0000 Subject: [PATCH] lib: remove unused includes Remove a bunch of includes that my IDE (VSCode + clangd) reports as unused. I didn't touch the logging and compat includes. Change-Id: I5fe2cb4a332f000dc7d9b8c015bcd6382684fc6c Signed-off-by: Simon Marchi Reviewed-on: https://review.lttng.org/c/babeltrace/+/11718 Reviewed-by: Philippe Proulx Tested-by: jenkins --- src/lib/assert-cond.c | 1 - src/lib/graph/component-class-sink-simple.c | 1 - src/lib/graph/component-descriptor-set.c | 1 - src/lib/graph/component.c | 2 -- src/lib/graph/connection.c | 1 - src/lib/graph/interrupter.c | 2 -- src/lib/graph/iterator.c | 2 -- src/lib/graph/message/event.c | 1 - src/lib/graph/query-executor.c | 1 - src/lib/lib-logging.c | 5 ----- src/lib/logging.c | 1 - src/lib/object-pool.c | 1 - src/lib/plugin/plugin-so.c | 1 - src/lib/plugin/plugin.c | 1 - src/lib/trace-ir/attributes.c | 2 -- src/lib/trace-ir/clock-snapshot.c | 2 -- src/lib/trace-ir/event-class.c | 5 ----- src/lib/trace-ir/event.c | 3 --- src/lib/trace-ir/field-class.c | 4 ---- src/lib/trace-ir/field-path.c | 3 --- src/lib/trace-ir/field.c | 1 - src/lib/trace-ir/packet.c | 3 --- src/lib/trace-ir/resolve-field-path.c | 2 -- src/lib/trace-ir/stream-class.c | 5 ----- src/lib/trace-ir/stream.c | 2 -- src/lib/trace-ir/trace-class.c | 11 +---------- src/lib/trace-ir/trace.c | 9 --------- 27 files changed, 1 insertion(+), 72 deletions(-) diff --git a/src/lib/assert-cond.c b/src/lib/assert-cond.c index b9959200..53505387 100644 --- a/src/lib/assert-cond.c +++ b/src/lib/assert-cond.c @@ -11,7 +11,6 @@ #include #include #include "common/assert.h" -#include "common/macros.h" #include "assert-cond-base.h" static diff --git a/src/lib/graph/component-class-sink-simple.c b/src/lib/graph/component-class-sink-simple.c index 801ddc62..c9a008d3 100644 --- a/src/lib/graph/component-class-sink-simple.c +++ b/src/lib/graph/component-class-sink-simple.c @@ -9,7 +9,6 @@ #include "common/assert.h" #include "common/common.h" -#include "lib/assert-cond.h" #include "lib/object.h" #include #include diff --git a/src/lib/graph/component-descriptor-set.c b/src/lib/graph/component-descriptor-set.c index d7ef275b..334f3e67 100644 --- a/src/lib/graph/component-descriptor-set.c +++ b/src/lib/graph/component-descriptor-set.c @@ -19,7 +19,6 @@ #include "component-class.h" #include "component-descriptor-set.h" -#include "component-class-sink-simple.h" #include "lib/value.h" static diff --git a/src/lib/graph/component.c b/src/lib/graph/component.c index 7b592b50..97fff9b6 100644 --- a/src/lib/graph/component.c +++ b/src/lib/graph/component.c @@ -18,9 +18,7 @@ #include "compat/compiler.h" #include #include -#include "lib/value.h" #include -#include #include "component.h" #include "component-class.h" diff --git a/src/lib/graph/connection.c b/src/lib/graph/connection.c index bb53dd09..da4429d0 100644 --- a/src/lib/graph/connection.c +++ b/src/lib/graph/connection.c @@ -8,7 +8,6 @@ #define BT_LOG_TAG "LIB/CONNECTION" #include "lib/logging.h" -#include "common/assert.h" #include "lib/assert-cond.h" #include #include "lib/object.h" diff --git a/src/lib/graph/interrupter.c b/src/lib/graph/interrupter.c index 6a2f018b..f52b0733 100644 --- a/src/lib/graph/interrupter.c +++ b/src/lib/graph/interrupter.c @@ -7,8 +7,6 @@ #define BT_LOG_TAG "LIB/INTERRUPTER" #include "lib/logging.h" -#include -#include #include #include "interrupter.h" diff --git a/src/lib/graph/iterator.c b/src/lib/graph/iterator.c index a76e325b..73893ddb 100644 --- a/src/lib/graph/iterator.c +++ b/src/lib/graph/iterator.c @@ -38,8 +38,6 @@ #include "component-class.h" #include "component.h" -#include "component-sink.h" -#include "component-source.h" #include "connection.h" #include "graph.h" #include "message-iterator-class.h" diff --git a/src/lib/graph/message/event.c b/src/lib/graph/message/event.c index 28bb1d4f..bbd99b7f 100644 --- a/src/lib/graph/message/event.c +++ b/src/lib/graph/message/event.c @@ -22,7 +22,6 @@ #include #include #include -#include #include "event.h" diff --git a/src/lib/graph/query-executor.c b/src/lib/graph/query-executor.c index 97a12caa..e331fcd4 100644 --- a/src/lib/graph/query-executor.c +++ b/src/lib/graph/query-executor.c @@ -7,7 +7,6 @@ #define BT_LOG_TAG "LIB/QUERY-EXECUTOR" #include "lib/logging.h" -#include "common/assert.h" #include "common/common.h" #include "lib/assert-cond.h" #include diff --git a/src/lib/lib-logging.c b/src/lib/lib-logging.c index b1cab494..bf70f468 100644 --- a/src/lib/lib-logging.c +++ b/src/lib/lib-logging.c @@ -27,17 +27,13 @@ #include "object-pool.h" #include "graph/interrupter.h" #include "graph/component-class.h" -#include "graph/component-filter.h" #include "graph/component.h" -#include "graph/component-sink.h" -#include "graph/component-source.h" #include "graph/connection.h" #include "graph/graph.h" #include "graph/message/discarded-items.h" #include "graph/message/event.h" #include "graph/message/iterator.h" #include "graph/message/message.h" -#include "graph/message/message-iterator-inactivity.h" #include "graph/message/packet.h" #include "graph/message/stream.h" #include "graph/port.h" @@ -55,7 +51,6 @@ #include "trace-ir/stream.h" #include "trace-ir/trace-class.h" #include "trace-ir/trace.h" -#include "trace-ir/utils.h" #include "error.h" #define LIB_LOGGING_BUF_SIZE (4096 * 4) diff --git a/src/lib/logging.c b/src/lib/logging.c index 0b341265..1e1cdf74 100644 --- a/src/lib/logging.c +++ b/src/lib/logging.c @@ -4,7 +4,6 @@ * Copyright 2017-2018 Philippe Proulx */ -#include #include #define BT_LOG_TAG "LIB/LOGGING" diff --git a/src/lib/object-pool.c b/src/lib/object-pool.c index 3b48dee9..cde13134 100644 --- a/src/lib/object-pool.c +++ b/src/lib/object-pool.c @@ -9,7 +9,6 @@ #include #include "common/assert.h" -#include "lib/assert-cond.h" #include "lib/object-pool.h" int bt_object_pool_initialize(struct bt_object_pool *pool, diff --git a/src/lib/plugin/plugin-so.c b/src/lib/plugin/plugin-so.c index 7887a21c..a4622c38 100644 --- a/src/lib/plugin/plugin-so.c +++ b/src/lib/plugin/plugin-so.c @@ -9,7 +9,6 @@ #include "lib/logging.h" #include "common/assert.h" -#include "lib/assert-cond.h" #include "compat/compiler.h" #include #include "lib/graph/component-class.h" diff --git a/src/lib/plugin/plugin.c b/src/lib/plugin/plugin.c index 67400177..8ee34e7f 100644 --- a/src/lib/plugin/plugin.c +++ b/src/lib/plugin/plugin.c @@ -24,7 +24,6 @@ #include #include #include -#include #include #include #include diff --git a/src/lib/trace-ir/attributes.c b/src/lib/trace-ir/attributes.c index 162bc4ec..8c9f1185 100644 --- a/src/lib/trace-ir/attributes.c +++ b/src/lib/trace-ir/attributes.c @@ -8,9 +8,7 @@ #define BT_LOG_TAG "LIB/ATTRS" #include "lib/logging.h" -#include "common/macros.h" #include -#include "lib/assert-cond.h" #include "lib/object.h" #include #include "lib/value.h" diff --git a/src/lib/trace-ir/clock-snapshot.c b/src/lib/trace-ir/clock-snapshot.c index 5e2c461c..cb45d56e 100644 --- a/src/lib/trace-ir/clock-snapshot.c +++ b/src/lib/trace-ir/clock-snapshot.c @@ -8,14 +8,12 @@ #include "lib/logging.h" #include "lib/assert-cond.h" -#include "common/uuid.h" #include "clock-class.h" #include "clock-snapshot.h" #include #include "compat/compiler.h" #include #include "compat/string.h" -#include #include "lib/object.h" #include "common/assert.h" #include "lib/func-status.h" diff --git a/src/lib/trace-ir/event-class.c b/src/lib/trace-ir/event-class.c index 463e5ee3..0d907175 100644 --- a/src/lib/trace-ir/event-class.c +++ b/src/lib/trace-ir/event-class.c @@ -21,16 +21,11 @@ #include #include -#include "attributes.h" -#include "clock-snapshot.h" #include "event-class.h" #include "event.h" #include "field-class.h" -#include "field.h" #include "resolve-field-path.h" #include "stream-class.h" -#include "trace.h" -#include "utils.h" #include "lib/func-status.h" #define BT_ASSERT_PRE_DEV_EVENT_CLASS_HOT(_ec) \ diff --git a/src/lib/trace-ir/event.c b/src/lib/trace-ir/event.c index 2a8676d8..a8ea1b38 100644 --- a/src/lib/trace-ir/event.c +++ b/src/lib/trace-ir/event.c @@ -16,7 +16,6 @@ #include #include "common/assert.h" #include "compat/compiler.h" -#include #include #include "field.h" @@ -25,9 +24,7 @@ #include "stream-class.h" #include "stream.h" #include "packet.h" -#include "trace.h" #include "packet.h" -#include "attributes.h" #include "event-class.h" void _bt_event_set_is_frozen(const struct bt_event *event, bool is_frozen) diff --git a/src/lib/trace-ir/field-class.c b/src/lib/trace-ir/field-class.c index 1990a690..0c1c82ca 100644 --- a/src/lib/trace-ir/field-class.c +++ b/src/lib/trace-ir/field-class.c @@ -17,16 +17,12 @@ #include "compat/endian.h" #include "common/assert.h" #include "compat/glib.h" -#include #include #include #include -#include "clock-class.h" #include "field-class.h" -#include "field.h" #include "field-path.h" -#include "utils.h" #include "lib/func-status.h" #include "lib/integer-range-set.h" #include "lib/value.h" diff --git a/src/lib/trace-ir/field-path.c b/src/lib/trace-ir/field-path.c index ab3d04a4..92bca3f1 100644 --- a/src/lib/trace-ir/field-path.c +++ b/src/lib/trace-ir/field-path.c @@ -11,13 +11,10 @@ #include "lib/assert-cond.h" #include #include -#include #include -#include #include "common/assert.h" #include -#include "field-class.h" #include "field-path.h" static diff --git a/src/lib/trace-ir/field.c b/src/lib/trace-ir/field.c index d1906c5f..f69cb87b 100644 --- a/src/lib/trace-ir/field.c +++ b/src/lib/trace-ir/field.c @@ -13,7 +13,6 @@ #include "lib/object.h" #include "compat/compiler.h" #include "compat/fcntl.h" -#include "common/align.h" #include "common/assert.h" #include #include diff --git a/src/lib/trace-ir/packet.c b/src/lib/trace-ir/packet.c index 02b9f9c2..3d8ab27a 100644 --- a/src/lib/trace-ir/packet.c +++ b/src/lib/trace-ir/packet.c @@ -14,7 +14,6 @@ #include #include "lib/object.h" #include "common/assert.h" -#include #include #include "field.h" @@ -22,8 +21,6 @@ #include "packet.h" #include "stream-class.h" #include "stream.h" -#include "trace.h" -#include "lib/func-status.h" BT_EXPORT struct bt_stream *bt_packet_borrow_stream(struct bt_packet *packet) diff --git a/src/lib/trace-ir/resolve-field-path.c b/src/lib/trace-ir/resolve-field-path.c index cc734cee..ecb75e99 100644 --- a/src/lib/trace-ir/resolve-field-path.c +++ b/src/lib/trace-ir/resolve-field-path.c @@ -10,10 +10,8 @@ #include "lib/assert-cond.h" #include "common/assert.h" #include -#include #include #include -#include #include #include "field-class.h" diff --git a/src/lib/trace-ir/stream-class.c b/src/lib/trace-ir/stream-class.c index 07c12afe..54da5afe 100644 --- a/src/lib/trace-ir/stream-class.c +++ b/src/lib/trace-ir/stream-class.c @@ -11,10 +11,8 @@ #include "lib/assert-cond.h" #include #include "compat/compiler.h" -#include "common/align.h" #include "compat/endian.h" #include "common/assert.h" -#include "lib/property.h" #include #include #include @@ -22,12 +20,9 @@ #include "clock-class.h" #include "event-class.h" #include "field-class.h" -#include "field.h" #include "field-wrapper.h" #include "resolve-field-path.h" #include "stream-class.h" -#include "trace.h" -#include "utils.h" #include "lib/value.h" #include "lib/func-status.h" diff --git a/src/lib/trace-ir/stream.c b/src/lib/trace-ir/stream.c index f85b4b23..7cb124f4 100644 --- a/src/lib/trace-ir/stream.c +++ b/src/lib/trace-ir/stream.c @@ -13,9 +13,7 @@ #include #include #include "compat/compiler.h" -#include "common/align.h" #include "common/assert.h" -#include "lib/property.h" #include #include #include diff --git a/src/lib/trace-ir/trace-class.c b/src/lib/trace-ir/trace-class.c index 15182149..24c8ddfd 100644 --- a/src/lib/trace-ir/trace-class.c +++ b/src/lib/trace-ir/trace-class.c @@ -11,8 +11,6 @@ #include "lib/assert-cond.h" #include #include -#include "ctf-writer/functor.h" -#include "ctf-writer/clock.h" #include "compat/compiler.h" #include #include "lib/value.h" @@ -26,16 +24,9 @@ #include #include -#include "clock-class.h" -#include "event-class.h" -#include "event.h" -#include "field-class.h" -#include "field-wrapper.h" -#include "resolve-field-path.h" +#include "trace-class.h" #include "stream-class.h" #include "stream.h" -#include "trace.h" -#include "utils.h" #include "lib/value.h" #include "lib/func-status.h" diff --git a/src/lib/trace-ir/trace.c b/src/lib/trace-ir/trace.c index 982325f7..8cc005a7 100644 --- a/src/lib/trace-ir/trace.c +++ b/src/lib/trace-ir/trace.c @@ -11,8 +11,6 @@ #include "lib/assert-cond.h" #include #include -#include "ctf-writer/functor.h" -#include "ctf-writer/clock.h" #include "compat/compiler.h" #include #include "lib/value.h" @@ -27,17 +25,10 @@ #include #include "attributes.h" -#include "clock-class.h" -#include "event-class.h" -#include "event.h" -#include "field-class.h" -#include "field-wrapper.h" -#include "resolve-field-path.h" #include "stream-class.h" #include "stream.h" #include "trace-class.h" #include "trace.h" -#include "utils.h" #include "lib/value.h" #include "lib/func-status.h" -- 2.34.1