From 4c06558d72d47c51b366c0f90df1880db7b63f8a Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Mon, 31 Jan 2022 10:34:20 -0500 Subject: [PATCH] src.ctf.lttng-live: remove unnecessary assignment in lttng_live_iterator_handle_new_streams_and_metadata Fix this clang-tidy warning: /home/simark/src/babeltrace/src/plugins/ctf/lttng-live/lttng-live.cpp:612:13: warning: Value stored to 'status' is never read [clang-analyzer-deadcode.DeadStores] status = LTTNG_LIVE_ITERATOR_STATUS_OK; ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ This value is indeed always overwritten in any case, in the if at the end of the function. Change-Id: I1899d07f389ae32abda34218b452d93d6d6a092b Signed-off-by: Simon Marchi Reviewed-on: https://review.lttng.org/c/babeltrace/+/7186 Tested-by: jenkins Reviewed-by: Philippe Proulx --- src/plugins/ctf/lttng-live/lttng-live.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/plugins/ctf/lttng-live/lttng-live.cpp b/src/plugins/ctf/lttng-live/lttng-live.cpp index 344fbe27..67ea8297 100644 --- a/src/plugins/ctf/lttng-live/lttng-live.cpp +++ b/src/plugins/ctf/lttng-live/lttng-live.cpp @@ -607,9 +607,7 @@ lttng_live_iterator_handle_new_streams_and_metadata(struct lttng_live_msg_iter * status = lttng_live_get_session(lttng_live_msg_iter, session); switch (status) { case LTTNG_LIVE_ITERATOR_STATUS_OK: - break; case LTTNG_LIVE_ITERATOR_STATUS_END: - status = LTTNG_LIVE_ITERATOR_STATUS_OK; break; default: goto end; -- 2.34.1