From 508b9546463484f40ffc524d0b64923e464b672c Mon Sep 17 00:00:00 2001 From: Francis Deslauriers Date: Mon, 16 Sep 2019 11:40:23 -0400 Subject: [PATCH] Cleanup: packet-context-field.c: logically dead code Coverity reported the following: CID 1401199 (#1 of 1): Logically dead code (DEADCODE)dead_error_begin: Execution cannot reach this statement: bt_field_wrapper_destroy Reported-by: Coverity - 1401199 Logically dead code (DEADCODE) Signed-off-by: Francis Deslauriers Change-Id: Ia53f46f998bcfb3a88f2d8a93343aa4c199a12ff Reviewed-on: https://review.lttng.org/c/babeltrace/+/2052 Tested-by: jenkins Reviewed-by: Simon Marchi --- src/lib/trace-ir/packet-context-field.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/src/lib/trace-ir/packet-context-field.c b/src/lib/trace-ir/packet-context-field.c index 9f648e24..786cbdf6 100644 --- a/src/lib/trace-ir/packet-context-field.c +++ b/src/lib/trace-ir/packet-context-field.c @@ -76,18 +76,11 @@ struct bt_packet_context_field *bt_packet_context_field_create( BT_LIB_LOGE_APPEND_CAUSE( "Cannot allocate one packet context field from stream class: " "%![sc-]+S", stream_class); - goto error; + goto end; } BT_ASSERT(field_wrapper->field); bt_stream_class_freeze(stream_class); - goto end; - -error: - if (field_wrapper) { - bt_field_wrapper_destroy(field_wrapper); - field_wrapper = NULL; - } end: return (void *) field_wrapper; -- 2.34.1