From 55c68a1a729551ca7d697d6e771064a06a19c206 Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Mon, 27 May 2019 14:50:19 -0400 Subject: [PATCH] Fix: sink.text.pretty: comma in enum fields The condition for printing commas that separate labels of enum fields is reversed. It causes a comma tu be spuriously printed before the first label: enumfield = ( , "zero" : container = 0 ) instead of: enumfield = ( "zero" : container = 0 ) With multiple matching labels, before: enumfield = ( , "zero""one" : container = 0 ) and after: enumfield = ( "zero", "one" : container = 0 Change-Id: I03452b8ece4f97bf0c819f6885ef512f7ddc31e6 Signed-off-by: Simon Marchi Reviewed-on: https://review.lttng.org/c/babeltrace/+/1334 Reviewed-by: Philippe Proulx --- plugins/text/pretty/print.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/text/pretty/print.c b/plugins/text/pretty/print.c index efcf2b88..a3f94b96 100644 --- a/plugins/text/pretty/print.c +++ b/plugins/text/pretty/print.c @@ -717,7 +717,7 @@ int print_enum(struct pretty_component *pretty, for (i = 0; i < label_count; i++) { const char *mapping_name = label_array[i]; - if (i == 0) { + if (i != 0) { g_string_append(pretty->string, ", "); } if (pretty->use_colors) { -- 2.34.1