From 6b66b7a98ed3e3a0056c6b157c3781efbda08770 Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Wed, 20 Nov 2019 11:15:30 -0500 Subject: [PATCH] tests: quote ${BT_CTF_TRACES_PATH} in test_trace_read and test_trace_copy Fixes these shellcheck errors: In test_trace_copy line 33: SUCCESS_TRACES=(${BT_CTF_TRACES_PATH}/succeed/*) ^-------------------^ SC2206: Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. In test_trace_read line 29: SUCCESS_TRACES=(${BT_CTF_TRACES_PATH}/succeed/*) ^-------------------^ SC2206: Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. In test_trace_read line 30: FAIL_TRACES=(${BT_CTF_TRACES_PATH}/fail/*) ^-------------------^ SC2206: Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. Reported-by: shellcheck Change-Id: Ia13810be69d2bc57f6d6541887de0f9d75e3ffe5 Signed-off-by: Simon Marchi Reviewed-on: https://review.lttng.org/c/babeltrace/+/2417 Tested-by: jenkins --- tests/cli/test_trace_copy | 2 +- tests/cli/test_trace_read | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/cli/test_trace_copy b/tests/cli/test_trace_copy index 15b1344b..5f902e17 100755 --- a/tests/cli/test_trace_copy +++ b/tests/cli/test_trace_copy @@ -30,7 +30,7 @@ clean_tmp() { rm -rf "${out_path}" "${text_output1}" "${text_output2_intermediary}" "${text_output2}" } -SUCCESS_TRACES=(${BT_CTF_TRACES_PATH}/succeed/*) +SUCCESS_TRACES=("${BT_CTF_TRACES_PATH}/succeed/"*) # -2 because there is an empty trace that we skip NUM_TESTS=$((${#SUCCESS_TRACES[@]} * 3 - 2)) diff --git a/tests/cli/test_trace_read b/tests/cli/test_trace_read index 5dd9c3db..e0ad90c2 100755 --- a/tests/cli/test_trace_read +++ b/tests/cli/test_trace_read @@ -26,8 +26,8 @@ fi # shellcheck source=../utils/utils.sh source "$UTILSSH" -SUCCESS_TRACES=(${BT_CTF_TRACES_PATH}/succeed/*) -FAIL_TRACES=(${BT_CTF_TRACES_PATH}/fail/*) +SUCCESS_TRACES=("${BT_CTF_TRACES_PATH}/succeed/"*) +FAIL_TRACES=("${BT_CTF_TRACES_PATH}/fail/"*) NUM_TESTS=$((${#SUCCESS_TRACES[@]} + ${#FAIL_TRACES[@]})) -- 2.34.1