From 72c6811a481b55f9a5541938b0b93c402467f32a Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Tue, 25 Feb 2020 14:33:53 -0500 Subject: [PATCH] tests: fix shellcheck warnings in plugins/sink.ctf.fs/succeed/test_succeed Fix: In test_succeed line 44: local temp_out_trace_dir="$(mktemp -d)" ^----------------^ SC2155: Declare and assign separately to avoid masking return values. In test_succeed line 73: local temp_gen_trace_dir="$(mktemp -d)" ^----------------^ SC2155: Declare and assign separately to avoid masking return values. Change-Id: I1d7d419d8a11458200d6bf97b1558c8183315dce Signed-off-by: Simon Marchi Reported-by: shellcheck Reviewed-on: https://review.lttng.org/c/babeltrace/+/3141 Tested-by: jenkins --- tests/plugins/sink.ctf.fs/succeed/test_succeed | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/plugins/sink.ctf.fs/succeed/test_succeed b/tests/plugins/sink.ctf.fs/succeed/test_succeed index 5c2547d6..f9c26a27 100755 --- a/tests/plugins/sink.ctf.fs/succeed/test_succeed +++ b/tests/plugins/sink.ctf.fs/succeed/test_succeed @@ -41,7 +41,9 @@ succeed_traces="$BT_CTF_TRACES_PATH/succeed" test_ctf_single() { local name="$1" local in_trace_dir="$2" - local temp_out_trace_dir="$(mktemp -d)" + local temp_out_trace_dir + + temp_out_trace_dir="$(mktemp -d)" diag "Converting trace '$name' to CTF through 'sink.ctf.fs'" "$BT_TESTS_BT2_BIN" >/dev/null "$in_trace_dir" -o ctf -w "$temp_out_trace_dir" @@ -70,7 +72,9 @@ test_ctf_existing_single() { test_ctf_gen_single() { local name="$1" - local temp_gen_trace_dir="$(mktemp -d)" + local temp_gen_trace_dir + + temp_gen_trace_dir="$(mktemp -d)" diag "Generating trace '$name'" -- 2.34.1