From 7569fbb1a48465f4399c7e3f8db72c9836c6ca8a Mon Sep 17 00:00:00 2001 From: Sebastian Andrzej Siewior Date: Tue, 27 May 2014 10:08:13 +0200 Subject: [PATCH] Fix: don't use a return code in _bt_ctf_stream_append_discarded_events MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit That function is defined as void: | File "/usr/lib/python3/dist-packages/babeltrace.py", line 2284, in | append_discarded_events | if ret < 0: | TypeError: unorderable types: NoneType() < int() Signed-off-by: Sebastian Andrzej Siewior Signed-off-by: Jérémie Galarneau --- bindings/python/babeltrace.i.in | 4 +--- include/babeltrace/ctf-writer/stream.h | 2 -- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/bindings/python/babeltrace.i.in b/bindings/python/babeltrace.i.in index 6a34e255..c0dd3a09 100644 --- a/bindings/python/babeltrace.i.in +++ b/bindings/python/babeltrace.i.in @@ -2088,9 +2088,7 @@ class CTFWriter: Increase the current packet's discarded event count. """ def append_discarded_events(self, event_count): - ret = _bt_ctf_stream_append_discarded_events(self._s, event_count) - if ret < 0: - raise ValueError("Could not append discarded events.") + _bt_ctf_stream_append_discarded_events(self._s, event_count) """ Append "event" to the stream's current packet. The stream's associated clock diff --git a/include/babeltrace/ctf-writer/stream.h b/include/babeltrace/ctf-writer/stream.h index 9229f771..df4d0c92 100644 --- a/include/babeltrace/ctf-writer/stream.h +++ b/include/babeltrace/ctf-writer/stream.h @@ -110,8 +110,6 @@ extern void bt_ctf_stream_class_put(struct bt_ctf_stream_class *stream_class); * @param stream Stream instance. * @param event_count Number of discarded events to add to the stream's current * packet. - * - * Returns 0 on success, a negative value on error. */ extern void bt_ctf_stream_append_discarded_events(struct bt_ctf_stream *stream, uint64_t event_count); -- 2.34.1