From 89ca8829438506a5137713ec1a6c8e1fab1bbedd Mon Sep 17 00:00:00 2001 From: Hui Zhu Date: Fri, 7 Sep 2012 09:16:55 -0400 Subject: [PATCH] Fix babeltrace-log uninitialized memory (v2) Got a crash with babeltrace-log. ../../../babeltrace/include/babeltrace/mmap-align.h:78 index=0, whence=0) at ../../../babeltrace/formats/ctf/ctf.c:623 at ../../../babeltrace/formats/ctf/ctf.c:576 _IO_2_1_stdin_ at ../../babeltrace/converter/babeltrace-log.c:233 ../../babeltrace/converter/babeltrace-log.c:342 This issue because pos is used before it init. This patch init it in function ctf_init_pos. Signed-off-by: Mathieu Desnoyers --- converter/babeltrace-log.c | 1 + 1 file changed, 1 insertion(+) diff --git a/converter/babeltrace-log.c b/converter/babeltrace-log.c index 6ac94e69..7f31d015 100644 --- a/converter/babeltrace-log.c +++ b/converter/babeltrace-log.c @@ -230,6 +230,7 @@ void trace_text(FILE *input, int output) char *line = NULL, *nl; size_t linesize; + memset(&pos, 0, sizeof(pos)); ctf_init_pos(&pos, output, O_RDWR); write_packet_header(&pos, s_uuid); -- 2.34.1