From 9270b61e78604bf36ccf3c7f12eb045a8fe6832e Mon Sep 17 00:00:00 2001 From: Mathieu Desnoyers Date: Wed, 26 Jul 2017 13:23:47 -0400 Subject: [PATCH] Fix: wrong variable in NULL check MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Found by Coverity: notnull: At condition impl_args, the value of impl_args cannot be NULL. dead_error_condition: The condition !impl_args cannot be true. CID 1376172 (#1 of 1): Logically dead code (DEADCODE)dead_error_begin: Execution cannot reach this statement: print_err_oom();. Signed-off-by: Mathieu Desnoyers Signed-off-by: Jérémie Galarneau --- cli/babeltrace-cfg-cli-args.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cli/babeltrace-cfg-cli-args.c b/cli/babeltrace-cfg-cli-args.c index 2978ab48..b48c6967 100644 --- a/cli/babeltrace-cfg-cli-args.c +++ b/cli/babeltrace-cfg-cli-args.c @@ -3553,7 +3553,7 @@ int fill_implicit_ctf_inputs_args(GPtrArray *implicit_ctf_inputs_args, BT_PUT(impl_args->extra_params); impl_args->extra_params = bt_value_copy(base_implicit_ctf_input_args->extra_params); - if (!impl_args) { + if (!impl_args->extra_params) { print_err_oom(); destroy_implicit_component_args(impl_args); goto error; -- 2.34.1