From a234ff436f775147f1e0a1d48938e94a9f60d373 Mon Sep 17 00:00:00 2001 From: Philippe Proulx Date: Fri, 10 Nov 2023 09:41:57 -0500 Subject: [PATCH] run-in-py-utils-bt2-env.sh: remove unneeded quotes Word splitting and globbing doesn't happen in those contexts. Removing them makes the code easier to read. Signed-off-by: Philippe Proulx Change-Id: I067b0a53098ed42f61ea45ec37fe1fa6b8ba4d2e --- tests/utils/run-in-py-env.sh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/utils/run-in-py-env.sh b/tests/utils/run-in-py-env.sh index 10b590e2..84788c56 100755 --- a/tests/utils/run-in-py-env.sh +++ b/tests/utils/run-in-py-env.sh @@ -5,10 +5,10 @@ # Copyright (C) 2017-2023 Philippe Proulx # Copyright (C) 2019 Simon Marchi -if [[ -n "${BT_TESTS_SRCDIR:-}" ]]; then - UTILSSH="$BT_TESTS_SRCDIR/utils/utils.sh" +if [[ -n ${BT_TESTS_SRCDIR:-} ]]; then + UTILSSH=$BT_TESTS_SRCDIR/utils/utils.sh else - UTILSSH="$(dirname "$0")/../utils/utils.sh" + UTILSSH=$(dirname "$0")/../utils/utils.sh fi # shellcheck source=../utils/utils.sh @@ -31,7 +31,7 @@ if (($# == 0)); then fi # Sanity check that the BT_TESTS_BUILDDIR value makes sense. -if [[ ! -f "$BT_TESTS_BUILDDIR/Makefile" ]]; then +if [[ ! -f $BT_TESTS_BUILDDIR/Makefile ]]; then { echo "ERROR: Invalid \`BT_TESTS_BUILDDIR\` variable (\`\$BT_TESTS_BUILDDIR/Makefile\`" echo "doesn't exist)." -- 2.34.1