From a7d6bdfd05c148bcb6ceae846fcee1af582d37ed Mon Sep 17 00:00:00 2001 From: Francis Deslauriers Date: Tue, 15 Oct 2019 19:06:43 -0400 Subject: [PATCH] Fix: ctf: query.c: Unchecked fclose() return value Coverity report: CID 1382583 (#1 of 1): Unchecked return value (CHECKED_RETURN)12. check_return: Calling fclose without checking return value (as is done elsewhere 9 out of 11 times). Reported-by: Coverity (1382583) Unchecked return value Signed-off-by: Francis Deslauriers Change-Id: Ic5f7d46992b823bcb0571853da4ca23dcefe3d35 Reviewed-on: https://review.lttng.org/c/babeltrace/+/2207 CI-Build: Jonathan Rajotte Julien Tested-by: jenkins Reviewed-by: Simon Marchi --- src/plugins/ctf/fs-src/query.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/plugins/ctf/fs-src/query.c b/src/plugins/ctf/fs-src/query.c index 33d9169c..cabb3683 100644 --- a/src/plugins/ctf/fs-src/query.c +++ b/src/plugins/ctf/fs-src/query.c @@ -171,7 +171,11 @@ end: ctf_metadata_decoder_destroy(decoder); if (metadata_fp) { - fclose(metadata_fp); + ret = fclose(metadata_fp); + if (ret) { + BT_LOGE_ERRNO("Cannot close metatada file stream", + ": path=\"%s\"", path); + } } *user_result = result; -- 2.34.1