From b93293f64299d1d7ef7a55a67e42b27fa2262f19 Mon Sep 17 00:00:00 2001 From: Mathieu Desnoyers Date: Fri, 14 Aug 2015 14:55:11 -0400 Subject: [PATCH] Fix: don't access missing ctf trace when getting metadata MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit We can get metadata when still in the trace open functions, in which case the ctf trace is not allocated nor available yet. This fixes a segmentation fault in stress-test. Signed-off-by: Mathieu Desnoyers Signed-off-by: Julien Desfossez Signed-off-by: Jérémie Galarneau --- formats/lttng-live/lttng-live-comm.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/formats/lttng-live/lttng-live-comm.c b/formats/lttng-live/lttng-live-comm.c index 2b793e5f..8059b338 100644 --- a/formats/lttng-live/lttng-live-comm.c +++ b/formats/lttng-live/lttng-live-comm.c @@ -607,6 +607,11 @@ int append_metadata(struct lttng_live_ctx *ctx, struct lttng_live_viewer_stream *metadata; char *metadata_buf = NULL; + if (!viewer_stream->ctf_trace->handle) { + printf_verbose("append_metadata: trace handle not ready yet.\n"); + return 0; + } + printf_verbose("get_next_index: new metadata needed\n"); ret = get_new_metadata(ctx, viewer_stream, &metadata_buf); if (ret < 0) { -- 2.34.1