From c4e511dfb2a168ee45764b6f6e6190c400b76b4b Mon Sep 17 00:00:00 2001 From: Mathieu Desnoyers Date: Thu, 31 Oct 2013 15:04:01 -0400 Subject: [PATCH] ctf-writer: fix linter defects Coverity found the following defects: ** CID 1124098: Unchecked return value (CHECKED_RETURN) /formats/ctf/writer/event-types.c: 200 ** CID 1124097: Unchecked return value (CHECKED_RETURN) /formats/ctf/writer/writer.c: 376 Signed-off-by: Mathieu Desnoyers --- formats/ctf/writer/event-types.c | 4 +++- formats/ctf/writer/writer.c | 5 ++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/formats/ctf/writer/event-types.c b/formats/ctf/writer/event-types.c index 9b74b6e1..091b3209 100644 --- a/formats/ctf/writer/event-types.c +++ b/formats/ctf/writer/event-types.c @@ -190,6 +190,7 @@ static void bt_ctf_field_type_init(struct bt_ctf_field_type *type) { enum ctf_type_id type_id = type->declaration->id; + int ret; assert(type && (type_id > CTF_TYPE_UNKNOWN) && (type_id < NR_CTF_TYPES)); @@ -197,7 +198,8 @@ void bt_ctf_field_type_init(struct bt_ctf_field_type *type) bt_ctf_ref_init(&type->ref_count); type->freeze = type_freeze_funcs[type_id]; type->serialize = type_serialize_funcs[type_id]; - bt_ctf_field_type_set_byte_order(type, BT_CTF_BYTE_ORDER_NATIVE); + ret = bt_ctf_field_type_set_byte_order(type, BT_CTF_BYTE_ORDER_NATIVE); + assert(!ret); type->declaration->alignment = 1; } diff --git a/formats/ctf/writer/writer.c b/formats/ctf/writer/writer.c index d0fad8fb..8529a1e3 100644 --- a/formats/ctf/writer/writer.c +++ b/formats/ctf/writer/writer.c @@ -356,6 +356,7 @@ void append_trace_metadata(struct bt_ctf_writer *writer, struct metadata_context *context) { unsigned char *uuid = writer->uuid; + int ret; g_string_append(context->string, "trace {\n"); @@ -374,7 +375,9 @@ void append_trace_metadata(struct bt_ctf_writer *writer, g_string_append(context->string, "\tpacket.header := "); context->current_indentation_level++; g_string_assign(context->field_name, ""); - bt_ctf_field_type_serialize(writer->trace_packet_header_type, context); + ret = bt_ctf_field_type_serialize(writer->trace_packet_header_type, + context); + assert(!ret); context->current_indentation_level--; g_string_append(context->string, ";\n};\n\n"); -- 2.34.1