From c7d2f7b637ef8533b9d0fdbe9d84828693ff99e4 Mon Sep 17 00:00:00 2001 From: Philippe Proulx Date: Fri, 16 Aug 2019 14:24:27 -0400 Subject: [PATCH] Fix: field-class.c: dereference before `NULL` check Found by Coverity Scan. Signed-off-by: Philippe Proulx Change-Id: Iaf80ac22f38e3a9dc5d09a69ac5729ece7cdd2f3 Reviewed-on: https://review.lttng.org/c/babeltrace/+/1957 Tested-by: jenkins --- src/lib/trace-ir/field-class.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/lib/trace-ir/field-class.c b/src/lib/trace-ir/field-class.c index 97409dc9..610f8f75 100644 --- a/src/lib/trace-ir/field-class.c +++ b/src/lib/trace-ir/field-class.c @@ -799,9 +799,8 @@ void destroy_named_field_class(gpointer ptr) { struct bt_named_field_class *named_fc = ptr; - BT_OBJECT_PUT_REF_AND_RESET(named_fc->user_attributes); - if (ptr) { + BT_OBJECT_PUT_REF_AND_RESET(named_fc->user_attributes); finalize_named_field_class(ptr); g_free(ptr); } -- 2.34.1